Fix compatibility with rspec-puppet 4+ #331
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These settings where used for compatibility with Puppet 7.10 and older (Puppet 7.10 was released more than 2 years ago). rspec-puppet 4 removed them: puppetlabs/rspec-puppet#73 In order to avoid this kind of accident in the future, add an upper bound on the rspec-puppet dependency. Version 5.0.0 is also working with this change, so accept anything before 6.0.0.
|
CI is still failing because it depends on this to be merged: |
|
Thanks for this @smortex! I ended up fixing this in a larger upgrade effort but thanks for the tips |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These settings where used for compatibility with Puppet 7.10 and older
(Puppet 7.10 was released more than 2 years ago). rspec-puppet 4
removed them:
puppetlabs/rspec-puppet#73
In order to avoid this kind of accident in the future, add an upper
bound on the rspec-puppet dependency. Version 5.0.0 is also working
with this change, so accept anything before 6.0.0.