Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add full Amazon 2 support #1887

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Add full Amazon 2 support #1887

merged 1 commit into from
Jun 4, 2024

Conversation

joshcooper
Copy link
Contributor

@joshcooper joshcooper commented Jun 3, 2024

Copies Amazon 7 to 2, as the former is an implementation detail and the latter is the actual OS version: https://aws.amazon.com/amazon-linux-2

I was able to run facter beaker tests with this PR and voxpupuli/beaker-hostgenerator#372

❯ env | grep BEAKER                                                                                     
BEAKER_VERSION=https://github.com/voxpupuli/beaker#amazon2
BEAKER_PUPPET_VERSION=~> 4.0
BEAKER_HOSTGENERATOR_VERSION=https://github.com/voxpupuli/beaker-hostgenerator#amazon2
❯ cd ~/work/facter/acceptance
❯ bundle update
❯ env SHA=c6c5de5b1457d0cad36bcbb0ee94ec3c3486014d HOSTS=amazon2-AARCH64a bundle exec rake ci:test:setup
...
❯ bundle exec beaker exec tests
... SNIP...
      - Host Configuration Summary -


              - Test Case Summary for suite 'tests' -
       Total Suite Time: 500.02 seconds
      Average Test Time: 2.96 seconds
              Attempted: 169
                 Passed: 147
                 Failed: 0
                Errored: 0
                Skipped: 22
                Pending: 0
                  Total: 169

      - Specific Test Case Status -
        
Failed Tests Cases:
Errored Tests Cases:
Skipped Tests Cases:
  Test Case tests/api/value/core_and_custom.rb 
  Test Case tests/api/value/core_and_custom_overwrite.rb 
  Test Case tests/api/value/core_fact.rb 
  Test Case tests/api/value/custom_fact_in_different_file.rb 
  Test Case tests/api/value/custom_fact_in_same_file_as_fact_name.rb 
  Test Case tests/api/value/env_fact.rb 
  Test Case tests/api/value/external_fact.rb 
  Test Case tests/api/value/non_existent_fact.rb 
  Test Case tests/custom_facts/expand_command.rb 
  Test Case tests/custom_facts/not_expand_command.rb 
  Test Case tests/custom_facts/using_win32ole_should_not_hang.rb 
  Test Case tests/custom_facts/windows_not_expand_command.rb 
  Test Case tests/facts/mountpoints_fact.rb 
  Test Case tests/facts/nim_type.rb 
  Test Case tests/facts/operatingsystem_detection_after_clear_on_ubuntu.rb 
  Test Case tests/facts/osx_numeric_hostname.rb 
  Test Case tests/facts/validate_file_system_size_bytes.rb 
  Test Case tests/facts/windows_os.rb 
  Test Case tests/options/config_file/ttls/cached_custom_group_core_custom_facts.rb 
  Test Case tests/options/config_file/ttls_cached_facts_that_are_empty_return_an_empty_value.rb 
  Test Case tests/options/config_file/ttls_external_facts_in_custom_groups.rb 
  Test Case tests/options/puppet_facts.rb 
Pending Tests Cases:

Copies Amazon 7 to 2, as the former is an implementation detail and the
latter is the actual OS version: https://aws.amazon.com/amazon-linux-2
@joshcooper joshcooper marked this pull request as ready for review June 4, 2024 01:33
@bastelfreak bastelfreak merged commit 9927228 into master Jun 4, 2024
7 checks passed
@bastelfreak bastelfreak deleted the amazon2 branch June 4, 2024 06:34
@bastelfreak bastelfreak changed the title Add Amazon 2 Add full Amazon 2 support Jun 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants