Skip to content

Commit

Permalink
Rubocop: Enable Naming/VariableNumber
Browse files Browse the repository at this point in the history
I would like to clean up our .rubocop.yaml to follow our standards. I
think enabling this cop makes sense, except for the
`determine_if_x86_64` method. rubocop prefers `determine_if_x8664` but
since `x86_64` is it's own name I disable the cop for this function.
  • Loading branch information
bastelfreak committed May 11, 2024
1 parent 7a8f2ad commit 16284c9
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 9 deletions.
6 changes: 3 additions & 3 deletions .rubocop.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,9 +22,6 @@ Naming/MethodParameterName:
Naming/PredicateName:
Enabled: false

Naming/VariableNumber:
Enabled: false

RSpec/DescribeClass:
Exclude:
- acceptance/fixtures/module/spec/**/*.rb
Expand All @@ -49,3 +46,6 @@ RSpec/NestedGroups:

Style:
Enabled: false

Naming/VariableNumber:
AllowedPatterns: ['x86_64']
12 changes: 6 additions & 6 deletions acceptance/fixtures/module/spec/acceptance/demo_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -22,15 +22,15 @@
end

it "is able to apply manifests" do
manifest_1 = "user {'foo':
manifest1 = "user {'foo':
ensure => present,}"
manifest_2 = "user {'foo':
manifest2 = "user {'foo':
ensure => absent,}"
manifest_3 = "user {'root':
manifest3 = "user {'root':
ensure => present,}"
apply_manifest(manifest_1, :expect_changes => true)
apply_manifest(manifest_2, :expect_changes => true)
apply_manifest(manifest_3)
apply_manifest(manifest1, :expect_changes => true)
apply_manifest(manifest2, :expect_changes => true)
apply_manifest(manifest3)
end

describe service('sshd') do
Expand Down

0 comments on commit 16284c9

Please sign in to comment.