-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(PA-5948) Update host generator to use aarch64 for amazon linux #345
(PA-5948) Update host generator to use aarch64 for amazon linux #345
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #345 +/- ##
======================================
Coverage 0.72% 0.72%
======================================
Files 15 15
Lines 1801 1801
======================================
Hits 13 13
Misses 1788 1788 ☔ View full report in Codecov by Sentry. |
29c3762
to
95e130e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I think we need one more change here. The goal is to have BHG generate a platform
that is appropriate for our Vanagon projects, but a template
that is appropriate for ABS/VMPooler. Right now, your PR generates this:
bundle exec beaker-hostgenerator amazon2023-AARCH64a --hypervisor abs
---
HOSTS:
amazon2023-AARCH64-1:
platform: amazon-2023-aarch64
hypervisor: abs
template: amazon-2023-aarch64
roles:
- agent
CONFIG: {}
For our CI, we need the template
to match what's in ABS/VMPooler, which is amazon-2023-arm64
.
In addition to what you already have here, we need to move Amazon to this regex line:
when /^(debian|ubuntu)/ |
So we get this desired result:
bundle exec beaker-hostgenerator amazon2023-AARCH64a --hypervisor abs
---
HOSTS:
amazon2023-AARCH64-1:
platform: amazon-2023-aarch64
hypervisor: abs
template: amazon-2023-arm64
roles:
- agent
CONFIG: {}
95e130e
to
40fa043
Compare
LGTM, I'm not sure what we need to do to make Codecov happy |
@mhashizume just ignore it :) |
Updated data.rb in host-generator to use 'aarch64' like it is using everywhere in project