Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(PA-5948) Update host generator to use aarch64 for amazon linux #345

Conversation

span786
Copy link
Contributor

@span786 span786 commented Nov 17, 2023

Updated data.rb in host-generator to use 'aarch64' like it is using everywhere in project

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (64f3152) 0.72% compared to head (40fa043) 0.72%.

Files Patch % Lines
lib/beaker-hostgenerator/hypervisor/abs.rb 0.00% 2 Missing ⚠️
lib/beaker-hostgenerator/data.rb 0.00% 1 Missing ⚠️
Additional details and impacted files
@@          Coverage Diff           @@
##           master    #345   +/-   ##
======================================
  Coverage    0.72%   0.72%           
======================================
  Files          15      15           
  Lines        1801    1801           
======================================
  Hits           13      13           
  Misses       1788    1788           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mhashizume mhashizume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I think we need one more change here. The goal is to have BHG generate a platform that is appropriate for our Vanagon projects, but a template that is appropriate for ABS/VMPooler. Right now, your PR generates this:

bundle exec beaker-hostgenerator amazon2023-AARCH64a --hypervisor abs
---
HOSTS:
  amazon2023-AARCH64-1:
    platform: amazon-2023-aarch64
    hypervisor: abs
    template: amazon-2023-aarch64
    roles:
    - agent
CONFIG: {}

For our CI, we need the template to match what's in ABS/VMPooler, which is amazon-2023-arm64.

In addition to what you already have here, we need to move Amazon to this regex line:

So we get this desired result:

bundle exec beaker-hostgenerator amazon2023-AARCH64a --hypervisor abs
---
HOSTS:
  amazon2023-AARCH64-1:
    platform: amazon-2023-aarch64
    hypervisor: abs
    template: amazon-2023-arm64
    roles:
    - agent
CONFIG: {}

@span786 span786 force-pushed the PA-5948-update-beaker-hostgenerator-to-use-aarch-64-for-amazon-linux branch from 95e130e to 40fa043 Compare November 20, 2023 06:24
@bastelfreak bastelfreak changed the title PA-5948 : Updated host generator to use aarch64 for amazon linux (PA-5948) Update host generator to use aarch64 for amazon linux Nov 20, 2023
@mhashizume mhashizume added the bug label Nov 20, 2023
@mhashizume
Copy link
Contributor

LGTM, I'm not sure what we need to do to make Codecov happy

@bastelfreak
Copy link
Member

@mhashizume just ignore it :)

@bastelfreak bastelfreak merged commit df767f9 into voxpupuli:master Nov 20, 2023
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants