Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add the latest tag to the docker image #79

Merged
merged 6 commits into from
Aug 22, 2024

Conversation

prmoore77
Copy link
Contributor

@prmoore77 prmoore77 commented Aug 22, 2024

This PR also fixes the client-demo when the server is run in
a Docker or Kubernetes (k8s) environment.

@prmoore77 prmoore77 requested a review from amoeba August 22, 2024 13:17
Copy link

ACTION NEEDED

Substrait follows the Conventional Commits
specification
for
release automation.

The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification.

@prmoore77 prmoore77 changed the title Add the latest tag to the Docker image if it is the main branch feat: Add the latest tag to the Docker image if it is the main branch Aug 22, 2024
@prmoore77 prmoore77 changed the title feat: Add the latest tag to the Docker image if it is the main branch feat: add the latest tag to the Docker image if it is the main branch Aug 22, 2024
@prmoore77 prmoore77 changed the title feat: add the latest tag to the Docker image if it is the main branch feat: add the latest tag to the docker image if it is the main branch Aug 22, 2024
@prmoore77 prmoore77 changed the title feat: add the latest tag to the docker image if it is the main branch feat: add the latest tag to the docker image Aug 22, 2024
@@ -83,3 +83,4 @@ spark-substrait-gateway-server = "gateway.server:click_serve"
spark-substrait-client-demo = "gateway.demo.client_demo:click_run_demo"
spark-substrait-create-tls-keypair = "gateway.setup.tls_utilities:click_create_tls_keypair"
spark-substrait-create-jwt = "gateway.utilities.create_jwt:main"
spark-substrait-create-client-demo-data = "gateway.demo.generate_tpch_parquet_data:click_generate_tpch_parquet_data"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we also want to include the TPC-DS data or would we rather keep the footprint of the image small?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could potentially add it - I just targeted to TPC-H b/c that is what the client-demo file needed. Would doing it in a later PR be ok, if needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, no need to overbuild this.

src/gateway/demo/generate_tpch_parquet_data.py Outdated Show resolved Hide resolved
@prmoore77 prmoore77 merged commit 7e482a5 into voltrondata:main Aug 22, 2024
16 of 18 checks passed
@prmoore77 prmoore77 deleted the feature/add-latest-tag branch August 22, 2024 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants