-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add the latest tag to the docker image #79
Conversation
ACTION NEEDED Substrait follows the Conventional Commits The PR title and description are used as the merge commit message. Please update your PR title and description to match the specification. |
@@ -83,3 +83,4 @@ spark-substrait-gateway-server = "gateway.server:click_serve" | |||
spark-substrait-client-demo = "gateway.demo.client_demo:click_run_demo" | |||
spark-substrait-create-tls-keypair = "gateway.setup.tls_utilities:click_create_tls_keypair" | |||
spark-substrait-create-jwt = "gateway.utilities.create_jwt:main" | |||
spark-substrait-create-client-demo-data = "gateway.demo.generate_tpch_parquet_data:click_generate_tpch_parquet_data" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we also want to include the TPC-DS data or would we rather keep the footprint of the image small?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could potentially add it - I just targeted to TPC-H b/c that is what the client-demo file needed. Would doing it in a later PR be ok, if needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, no need to overbuild this.
This PR also fixes the client-demo when the server is run in
a Docker or Kubernetes (k8s) environment.