Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[distro] refactor: cleanup dependencies in setup script #37

Merged
merged 3 commits into from
Dec 17, 2024
Merged

[distro] refactor: cleanup dependencies in setup script #37

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
4e211ba
[distro] refactor: cleanup dependencies in setup script
eric-haibin-lin Dec 4, 2024
91cce97
Update requirements.txt
eric-haibin-lin Dec 4, 2024
78181a1
Merge branch 'main' into hlin/deps
eric-haibin-lin Dec 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 11 additions & 9 deletions requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
transformers
hydra-core
tensordict==0.5.0
numpy
pytest
pybind11
# vllm==0.6.3 # vllm is installed in image building to avoid ray conflicts
# TODO: add version info to requirements
accelerate
codetiming
yapf
wandb
git+https://github.com/NVIDIA/TransformerEngine.git@stable
datasets
dill
hydra-core
numpy
pybind11
ray==2.10
tensordict
transformers
22 changes: 6 additions & 16 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,29 +20,19 @@
with open(os.path.join(version_folder, 'verl/version/version')) as f:
__version__ = f.read().strip()

# TODO: add version info to requirements
install_requires = [
'torch==2.4.0',
'tensordict',
'transformers',
'codetiming',
'pybind11',
'hydra-core',
'numpy',
'yapf',
"dill",
"accelerate"
]

with open('requirements.txt') as f:
required = f.read().splitlines()
install_requires = [item.strip() for item in required if item.strip()[0] != '#']

install_optional = [
'vllm==0.6.3',
'torch==2.4.0', # required by vllm
]

extras_require = {
'demo': ['hydra-core', 'transformers', ''],
'single-controller': ['ray', 'kubernetes'],
'single-controller-ray': ['ray'],
'test': ['fsspec', 'pytest', 'datasets']
'test': ['pytest']
}

from pathlib import Path
Expand Down
Loading