Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] fix: make wandb optional dependency. allow extra args in existing scripts #32

Merged
merged 3 commits into from
Dec 3, 2024
Merged

[example] fix: make wandb optional dependency. allow extra args in existing scripts #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
af7fa67
[deps] fix: make wandb optional dependency
eric-haibin-lin Dec 2, 2024
d922f7d
allow ppo scripts to take additional args
eric-haibin-lin Dec 2, 2024
bbf2d4b
fix lint
eric-haibin-lin Dec 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_deepseek7b_llm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,4 +35,4 @@ python3 -m verl.trainer.main_ppo \
trainer.n_gpus_per_node=8 \
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_deepseek_full_hh_rlhf.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megat
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.test_freq=5 \
trainer.total_epochs=100
trainer.total_epochs=100 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_deepseek_math_gsm8k_megatron.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,4 +37,4 @@ python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megat
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.test_freq=5 \
trainer.total_epochs=100
trainer.total_epochs=100 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_deepseek_megatron.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,4 @@ python3 -m verl.trainer.main_ppo --config-path=./config --config-name='ppo_megat
trainer.n_gpus_per_node=8 \
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_gemma.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,4 +36,4 @@ python3 -m verl.trainer.main_ppo \
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.test_freq=10 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_qwen2-7b.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,4 +44,4 @@ python3 -m verl.trainer.main_ppo \
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.test_freq=10 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_qwen2-7b_rm.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,4 +51,4 @@ python3 -m verl.trainer.main_ppo \
trainer.nnodes=1 \
trainer.save_freq=-1 \
trainer.test_freq=5 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
2 changes: 1 addition & 1 deletion examples/ppo_trainer/run_qwen2.5-32b.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,4 +45,4 @@ python3 -m verl.trainer.main_ppo \
trainer.nnodes=4 \
trainer.save_freq=-1 \
trainer.test_freq=10 \
trainer.total_epochs=15
trainer.total_epochs=15 $@
3 changes: 1 addition & 2 deletions verl/utils/tracking.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,8 +15,6 @@
A unified tracking interface that supports logging data to different backend
"""

import wandb

from typing import List, Union


Expand All @@ -32,6 +30,7 @@ def __init__(self, project_name, experiment_name, default_backend: Union[str, Li
self.logger = {}

if 'tracking' in default_backend:
import wandb
wandb.init(project=project_name, name=experiment_name, config=config)
self.logger['tracking'] = wandb

Expand Down
Loading