-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Integrating vllm>=0.7.0 #209
Open
ZSL98
wants to merge
22
commits into
volcengine:main
Choose a base branch
from
ZSL98:latest
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+1,288
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PeterSH6
reviewed
Feb 6, 2025
self.collective_rpc("verl_init_device") | ||
self.collective_rpc("load_model") | ||
|
||
def determine_num_available_blocks(self) -> Tuple[int, int]: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder why we need this function? It seems that vLLM UniProcExecutor
already perform allreduce MIN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have removed this file.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to integrate vllm>=0.7.0 and preserve:
Backward compatibility: 0.3.1, 0.4.2, 0.5.4, 0.6.3 are still supported
Forward compatibility: Future versions of vllm (>= 0.7.0) will be supported without requiring manual maintenance for each new release.
The integration up to now only supports the fsdp backend. We have some rough numbers (vllm generation time in seconds in an iteration) for comparison. We are happy to see that with eager mode off, the generation time is shorten with the help of cuda graph. The sleep mode of vllm helps to reduce GPU memory pressure.
To reproduce
pip3 install vllm==0.7.0
orpip install vllm --pre --extra-index-url https://wheels.vllm.ai/nightly
.local_rank = rank
tolocal_rank = int(os.environ["LOCAL_RANK"])
bash run_qwen2-7b.sh
under examples/ppo_trainerNote
The test cases are currently limited, and bug-free operation is not guaranteed at this stage.