[perf] feat: support ref/rm offload #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
vermouth1992
commented
Jan 21, 2025
•
vermouth1992
commented
- Force ref/rm to use CPUOffload. Fix root FSDP unit not reshard weights after forward
- HSDP support is on hold and assert False right now.
PeterSH6
reviewed
Jan 22, 2025
verl/workers/fsdp_workers.py
Outdated
| @@ -838,8 +869,9 @@ def _build_model(self, config): | |||
| device_id=torch.cuda.current_device(), | |||
| sharding_strategy=ShardingStrategy.FULL_SHARD, # zero3 | |||
There was a problem hiding this comment.
We should use HybridShard when the device mesh is 2D
vermouth1992
changed the title
vermouth1992
changed the title
vermouth1992
changed the title
PeterSH6
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.