Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add hypernodes validation webhook configuration yaml #3974

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Add hypernodes validation webhook configuration yaml #3974

merged 1 commit into from
Jan 20, 2025

Conversation

JesseStutler
Copy link
Member

What type of PR is this?

/kind feature
/area webhooks

What this PR does / why we need it:

  1. Add hypernode ValidationWebhookConfiguration yaml
  2. The validation of hypernode is not registered yet, fix it

Which issue(s) this PR fixes:

NONE

Special notes for your reviewer: NONE

Does this PR introduce a user-facing change?

NONE

validation:

  1. nil exactMatch and nil RegexMatch:
    image
  2. both specified exactMatch and RegexMatch:
    image
  3. qualified exact name:
    image
  4. valid regex pattern:
    image

@volcano-sh-bot volcano-sh-bot added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 18, 2025
@volcano-sh-bot volcano-sh-bot added area/webhooks size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jan 18, 2025
@JesseStutler
Copy link
Member Author

cc @hwdef @lowang-bh @Monokaix @william-wang

@Monokaix
Copy link
Member

/approve

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Monokaix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 20, 2025
hwdef
hwdef reviewed Jan 20, 2025
View reviewed changes
Copy link
Member

@hwdef hwdef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@volcano-sh-bot volcano-sh-bot added the lgtm Indicates that a PR is ready to be merged. label Jan 20, 2025
@hwdef
Copy link
Member

hwdef commented Jan 20, 2025

/ok-to-test

@volcano-sh-bot volcano-sh-bot added the ok-to-test Indicates a non-member PR verified by an org member that is safe to test. label Jan 20, 2025
@volcano-sh-bot volcano-sh-bot merged commit e6746d6 into volcano-sh:network-topology Jan 20, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hwdef hwdef hwdef left review comments

@merryzhou merryzhou Awaiting requested review from merryzhou

@Monokaix Monokaix Awaiting requested review from Monokaix

Assignees

@hwdef hwdef

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/webhooks kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JesseStutler @Monokaix @volcano-sh-bot @hwdef