Move GetAncestors as HyperNodeInfoMap method and provide GetLCAHyperNode #3969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
volcano-sh-bot
added
the
kind/feature
volcano-sh-bot
added
the
size/XXL
JesseStutler
changed the title
JesseStutler
force-pushed
the
network-informer-czc
branch
3 times, most recently
from
76f2321 to
2e8f63b
Compare
volcano-sh-bot
added
size/L
JesseStutler
changed the title
volcano-sh-bot
added
the
do-not-merge/work-in-progress
JesseStutler
force-pushed
the
network-informer-czc
branch
from
2e8f63b to
4cef8a1
Compare
JesseStutler
changed the title
volcano-sh-bot
removed
the
do-not-merge/work-in-progress
Monokaix
reviewed
Jan 15, 2025
Signed-off-by: JesseStutler <[email protected]>
JesseStutler
force-pushed
the
network-informer-czc
branch
from
4cef8a1 to
8044eb9
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Monokaix The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
volcano-sh-bot
added
the
approved
volcano-sh-bot
added
ok-to-test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
/area scheduling
What this PR does / why we need it:
Provide a
GetLCAHyperNodemethod for allocate action or network topology pluginWhich issue(s) this PR fixes:
NONE
Special notes for your reviewer:
hypernodesin HyperNodesInfo to a new type calledHyperNodeInfoMap, and moved theGetAncestors,getparentas its methods, therefore in allocate action or network topology plugin, it can callssn.HyperNodes.GetLCAHyperNodeto get the LCAHyperNodeHyperNodesin snapshot, cache and sessionGetAncestorschanged to return []string slice instead, this ensures that the order of the returned ancestors list is from child hypernode to ancestor hypernode, making it easier forGetLCAHyperNodeto find the LCAHyperNodeDoes this PR introduce a user-facing change?