-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip nodeaffinity, won't run Filter if PreFilter returned a Skip status #3185
base: master
Are you sure you want to change the base?
Skip nodeaffinity, won't run Filter if PreFilter returned a Skip status #3185
Conversation
Welcome @yuanhuaiwang! |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/assign @william-wang please take a look, thanks |
/assign @wangyang0616 |
plz help to review this pr, thanks |
In my opinion, the current PR modification is reasonable. Also, can you please add a verification case for this issue? @yuanhuaiwang |
Hi, the lastest master branch has introduced some new funcs like |
@yuanhuaiwang: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
The part of kind feature #3034,nodeAffinity can return Skip in PreFilter if the pod doesn't specify any node selector or affinity.