Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip nodeaffinity, won't run Filter if PreFilter returned a Skip status #3185

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

yuanhuaiwang
Copy link

@yuanhuaiwang yuanhuaiwang commented Nov 9, 2023

The part of kind feature #3034,nodeAffinity can return Skip in PreFilter if the pod doesn't specify any node selector or affinity.

  1. Volcano also adapts to the k8s v1.27
  2. In k8s v1.27, Scheduler skips nodeAffinity Filter plugin when nodeAffinity Filter plugin has nothing to do with a Pod. This update adapts to this change.

@volcano-sh-bot
Copy link
Contributor

Welcome @yuanhuaiwang!

It looks like this is your first PR to volcano-sh/volcano 馃帀.

Thank you, and welcome to Volcano. 😃

@volcano-sh-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign k82cn
You can assign the PR to them by writing /assign @k82cn in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@volcano-sh-bot volcano-sh-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 9, 2023
@yuanhuaiwang yuanhuaiwang changed the title feat: skip nodeaffinity, won't run Filter if PreFilter returned a Skip status Skip nodeaffinity, won't run Filter if PreFilter returned a Skip status Nov 13, 2023
@yuanhuaiwang
Copy link
Author

/assign @william-wang please take a look, thanks

@yuanhuaiwang
Copy link
Author

/assign @wangyang0616

@yuanhuaiwang
Copy link
Author

/assign @wangyang0616

plz help to review this pr, thanks

@wangyang0616
Copy link
Member

In my opinion, the current PR modification is reasonable.

Also, can you please add a verification case for this issue? @yuanhuaiwang

@Monokaix
Copy link
Member

Monokaix commented Mar 8, 2024

Hi, the lastest master branch has introduced some new funcs like handleSkipPredicatePlugin and handleSkipPrePredicatePlugin to handle preFilter case, please refactor your codes based on that : )

@volcano-sh-bot volcano-sh-bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 11, 2024
@volcano-sh-bot
Copy link
Contributor

@yuanhuaiwang: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

stale bot commented Feb 1, 2025

Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward?

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@stale stale bot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants