[WIP]Feature/support mig devices #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gilad Zamoscinski <[email protected]>
Signed-off-by: Gilad Zamoscinski <[email protected]>
Signed-off-by: Gilad Zamoscinski <[email protected]>
Signed-off-by: Gilad Zamoscinski <[email protected]>
Signed-off-by: Gilad Zamoscinski <[email protected]>
zamog
force-pushed
the
feature/support_mig_devices
branch
from
1dc7eab to
459ebd5
Compare
Thor-wl
requested review from
eggiter,
jasonliu747,
k82cn,
shinytang6,
william-wang and
xiaoanyunfei
|
@zamog, thanks for your contribution. |
Signed-off-by: Gilad Zamoscinski <[email protected]>
zamog
force-pushed
the
feature/support_mig_devices
branch
from
b012429 to
45d6920
Compare
|
Hi @zamog @william-wang Any update on this PR? |
|
@Sharathmk99 Well, it seems stable and has run in production for a long time. It's safe to merge, but it looks like we need to rework it on the latest version. @william-wang WDYT? |
|
Great work @zamog! Any ETA for this PR to be merged ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WIP