Core: Move the python check somewhere it can't accidentally be removed #1570
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to prevent accidental cleaning, convert the import that carries out the version check into explicit call, but move the constants value somewhere more obvious (as was the point of the original PR, #1364).
Upsides to this are that the python version lives somewhere sensible, downsides are there's technically a little more code (importing the interfaces, and the windows/linux constants) that it has to pass through. Not sure if it's worth it, or we just completely revert #1364. Sometimes tidying introduces unexpected problems and I'd sooner be safe that create the conditions for accidents to happen...