ssd.md: Implemented fstrim in a more general manner. Added instructions. #577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ns to TRIM on system start or shutdown.
ericonr
reviewed
Jul 4, 2021
|
|
||
| ``` | ||
| # fstrim / | ||
| # fstrim --fstab | ||
| ``` | ||
|
|
||
| To automate running TRIM, use cron or add the `discard` option to `/etc/fstab`. |
There was a problem hiding this comment.
You should mention the new method in this list: "To automate running TRIM, use cron, run fstrim at boot or shutdown time, or add the discard option to /etc/fstab.
Comment on lines
24
to
+27
| To automate running TRIM, use cron or add the `discard` option to `/etc/fstab`. | ||
| Note: using `discard` is not recommended. The `discard` method might cause the | ||
| system to slow down because it forces the system to apply TRIM instantly on | ||
| every individual file deletion. |
There was a problem hiding this comment.
I think this downside should be mentioned in the fstab section. Maybe use "add the appropriate mount option to /etc/fstab" above so people don't just use the option and move on without reading everything.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also implemented fstrim more generally. Added instructions on how to TRIM on system start or shutdown using rc.local or rc.shutdown.