Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.github/workflows/build: enable pushing to dockerhub #17

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

classabbyamp
Copy link
Member

despite dockerhub's checkered recent past, I think this is beneficial, especially as alpha.de's DNS no longer works, breaking people who use the current dockerhub container as-is. If we do this, we should be able to remove the old images and direct people to the new ones.

This will require dockerhub credentials be added as secrets.

@classabbyamp
Copy link
Member Author

we should also consider removing the old ghcr images so people migrate to the updated ones:

@leahneukirchen
Copy link
Member

Perhaps explicitly mention docker.io (iirc), so it's clear where it pushes.

@Anachron
Copy link

Anachron commented Mar 9, 2024

Is there a discussion I missed which speaks against merging this?

@classabbyamp
Copy link
Member Author

not really

@Anachron
Copy link

Anachron commented Aug 7, 2024

Still not sure why this is not being merged.

Is this just a "lets wait if something comes up against it" or do we actually need someone else to approve it?

@classabbyamp
Copy link
Member Author

probably because we've been doing other things

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants