Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enable gtmq (IN-1750) #292

Closed
wants to merge 4 commits into from
Closed

Conversation

theProf
Copy link
Contributor

@theProf theProf commented Nov 11, 2024

build(ci): orb voiceflow/[email protected]

build(ci): fail on bors staging branch

build(feat): labels for workflows

Copy link

linear bot commented Nov 11, 2024

Copy link

vercel bot commented Nov 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-chat ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 11, 2024 7:51pm

Copy link
Contributor Author

theProf commented Nov 11, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @theProf and the rest of your teammates on Graphite Graphite

@theProf theProf changed the title build(ci): orb voiceflow/[email protected] feat: enable gtmq (IN-1750) Nov 11, 2024
@theProf theProf marked this pull request as ready for review November 11, 2024 18:10
MERGE_REQUIRED_APPROVALS: '0'
MERGE_RETRY_SLEEP: '60000' # ms
MERGE_RETRIES: '15'
MERGE_READY_STATE: 'clean,unstable'
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The MERGE_COMMIT_MESSAGE_REGEX value appears to be set to a PR template fragment, which will prevent automerge from succeeding since commit messages won't match this specific pattern. Consider using (.*) to match any commit message, or remove the MERGE_COMMIT_MESSAGE_REGEX parameter entirely if commit message validation isn't needed for the breakglass workflow.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link
Contributor Author

theProf commented Nov 11, 2024

Merge activity

  • Nov 11, 2:13 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 2:21 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 2:22 PM EST: CI is running for this PR on a draft PR: #294
  • Nov 11, 2:23 PM EST: A user removed this pull request from the Graphite merge queue.
  • Nov 11, 2:38 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 2:38 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 2:38 PM EST: CI is running for this PR on a draft PR: #295
  • Nov 11, 2:40 PM EST: A user removed this pull request from the Graphite merge queue.
  • Nov 11, 2:41 PM EST: The merge label 'merge' was detected. This PR will be added to the Graphite merge queue once it meets the requirements.
  • Nov 11, 7:41 PM UTC: The merge label 'merge' was removed. This PR will no longer be merged by the Graphite merge queue
  • Nov 11, 2:42 PM EST: A user added this pull request to the Graphite merge queue.
  • Nov 11, 2:42 PM EST: CI is running for this PR on a draft PR: #296
  • Nov 11, 2:48 PM EST: A user merged this pull request with the Graphite merge queue via draft PR: #296.

theProf added a commit that referenced this pull request Nov 11, 2024
build(ci): orb voiceflow/[email protected]

build(ci): fail on bors staging branch

build(feat): labels for workflows
@graphite-app graphite-app bot removed the merge label Nov 11, 2024
Comment on lines +13 to +14
- name: Skip Vercel Preview Comments
run: echo "Skipping Vercel Preview Comments for gtmq_"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The echo statement alone won't prevent Vercel checks from running. To properly skip these checks, replace the run command with:

run: exit 0

This will successfully short-circuit the workflow with a successful status.

Spotted by Graphite Reviewer

Is this helpful? React 👍 or 👎 to let us know.

Copy link

sonarcloud bot commented Nov 11, 2024

@theProf theProf added the merge label Nov 11, 2024 — with Graphite App
theProf added a commit that referenced this pull request Nov 11, 2024
build(ci): orb voiceflow/[email protected]

build(ci): fail on bors staging branch

build(feat): labels for workflows
@graphite-app graphite-app bot removed the merge label Nov 11, 2024
theProf added a commit that referenced this pull request Nov 11, 2024
build(ci): orb voiceflow/[email protected]

build(ci): fail on bors staging branch

build(feat): labels for workflows
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant