Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: more jq and more logging #309

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

refactor: more jq and more logging #309

wants to merge 5 commits into from
+85 −53

Conversation

theProf
Copy link
Contributor

@theProf theProf commented Nov 13, 2024

No description provided.

@theProf Graphite App
Copy link
Contributor Author

theProf commented Nov 13, 2024 •
edited
Loading

This stack of pull requests is managed by Graphite. Learn more about stacking.

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 7d1923c to 4fb997e Compare November 13, 2024 02:54
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:4fb997e67229e7a49b67636841a346e79c2fa8ab

@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:6cd1791549d75d3aaa90c5ff9926a7567a756748

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 6cd1791 to bd7f3d5 Compare November 13, 2024 03:45
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:bd7f3d5ca01c6cbe00e747acd96dfd4aee16ebd4

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from bd7f3d5 to aae59e6 Compare November 13, 2024 04:04
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:aae59e6d1c4a4e88cd03f26853e798db1567e78e

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from aae59e6 to f07365b Compare November 13, 2024 04:10
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:f07365bd8183ad99caeb144e4d7d4bd65b1d4ce0

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from f07365b to a94c566 Compare November 13, 2024 04:28
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:a94c566e467199526148c4921f214897dcd7bd74

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from a94c566 to 292da8d Compare November 13, 2024 04:32
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:292da8dae225e01cc3ea05afde1a998403559e56

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 292da8d to a64355e Compare November 13, 2024 04:34
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:a64355ea0bbbb6488e81dbdf322b6db7409973f2

@theProf
Copy link
Contributor Author

theProf commented Nov 13, 2024

bors try

bors-vf bot added a commit that referenced this pull request Nov 13, 2024
@bors-vf
Try #309:
7f3c953
@bors-vf
Copy link

bors-vf bot commented Nov 13, 2024

try

Build succeeded:

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from a64355e to 4bed79c Compare November 13, 2024 04:40
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:4bed79cb8dfbcb0792b861ee4c0d01aea0182b4c

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 4bed79c to a526ac4 Compare November 13, 2024 04:50
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:a526ac4bea112affffd3d350bef4f5a04838fb77

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from a526ac4 to 2d049e9 Compare November 13, 2024 04:56
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:2d049e9a3408df81089ff2089ad610d4117ea72c

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 2d049e9 to 621f398 Compare November 13, 2024 05:01
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:621f398eb2f1aa6bb7a9d08dea98d4e50401d637

xavidop
xavidop requested changes Nov 13, 2024
View reviewed changes
Copy link
Contributor

@xavidop xavidop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This brakes the kubernetes state step: https://app.circleci.com/pipelines/github/voiceflow/platform/36700/workflows/5cfe6fe4-d825-4676-9578-a00219552bdc/jobs/170109

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from 621f398 to 5ecc694 Compare November 13, 2024 12:17
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:5ecc694b83b046f3ce92c7d5748ca76945704da0

@theProf theProf marked this pull request as ready for review November 13, 2024 12:18
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:0844b73c06cba1d4b81896d1f2295c22cfc4a65f

@theProf
Copy link
Contributor Author

theProf commented Nov 13, 2024

Test run: https://app.circleci.com/pipelines/github/voiceflow/platform/36711/workflows/1a8971ed-beca-400e-8226-df69de992cb2/jobs/170181/artifacts

However, awaiting feedback on if this has increased or decreased readability

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from f6c8bb9 to d0a45e9 Compare November 15, 2024 16:20
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:d0a45e92022a2b1147949e4f6166aba1624c41f9

@theProf theProf force-pushed the greg/refactor-status-wait/IN-000 branch from d0a45e9 to f68c6b0 Compare November 15, 2024 17:57
@vf-service-account
Copy link
Contributor

Your development orb has been published. It will expire in 30 days.
You can preview what this will look like on the CircleCI Orb Registry at the following link:
https://circleci.com/developer/orbs/orb/voiceflow/common?version=dev:f68c6b0429d788526286eca8ec2227ff09ea1ce3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xavidop xavidop xavidop requested changes

@effervescentia effervescentia Awaiting requested review from effervescentia

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@theProf @vf-service-account @xavidop