[Merged by Bors] - feat: add canEdit field to KB doc (VF-000) #466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -67,6 +67,7 @@ export interface KnowledgeBaseDocument { | |||
| status: { | |||
| type: KnowledgeBaseDocumentStatus; | |||
| data?: unknown; | |||
| canEdit?: boolean; | |||
There was a problem hiding this comment.
should only be available on the TEXT type, can move it to KnowledgeBaseText
JoshTheDeveloper
approved these changes
Nov 6, 2023
|
Kudos, SonarCloud Quality Gate passed!
|
|
bors r+ |
2 similar comments
|
bors r+ |
|
bors r+ |
|
bors ping |
|
pong |
bors-vf bot
pushed a commit
that referenced
this pull request
Nov 7, 2023
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements CV3-588** ### Brief description. What is this change? Add a canEdit field to the status object on the KB document. This is differentiate between a plain text kb object where the text is editable and a TXT file upload which cannot be edited.
|
bors r+ |
|
Already running a review |
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CV3-588
Brief description. What is this change?
Add a canEdit field to the status object on the KB document.
This is differentiate between a plain text kb object where the text is editable and a TXT file upload which cannot be edited.