[Merged by Bors] - feat: adding serialized check (CV3-289) #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhihil
force-pushed
the
brennan/change-reset-password-error/CV3-289
branch
from
a503794
to
18c4366
Compare
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements CV3-289** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion --> Adding a new static method to `HTTPException` to check if a plain object is an instance of a serialized `HTTPException`. The reason this method should be added as part of the `HTTPException` API is because the `HTTPException` is often serialized and transmitted over the wire to a different service. The client service which receives the serialized `HTTPException` needs a method to detect that the error payload is of shape `SerializedHTTPException` and not something else like a basic JavaScript `Error`. This is a very common use-case. Without this method, every client has to implement the duck-typing check for `SerializedHTTPException` to proper handle this exception. This creates duplication.
|
Timed out. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
bors r+ |
bors-vf bot
pushed a commit
that referenced
this pull request
Oct 12, 2023
<!-- You can erase any parts of this template not applicable to your Pull Request. --> **Fixes or implements CV3-289** ### Brief description. What is this change? <!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion --> Adding a new static method to `HTTPException` to check if a plain object is an instance of a serialized `HTTPException`. The reason this method should be added as part of the `HTTPException` API is because the `HTTPException` is often serialized and transmitted over the wire to a different service. The client service which receives the serialized `HTTPException` needs a method to detect that the error payload is of shape `SerializedHTTPException` and not something else like a basic JavaScript `Error`. This is a very common use-case. Without this method, every client has to implement the duck-typing check for `SerializedHTTPException` to proper handle this exception. This creates duplication.
|
Pull request successfully merged into master. Build succeeded: |
bors-vf
bot
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes or implements CV3-289
Brief description. What is this change?
Adding a new static method to
HTTPExceptionto check if a plain object is an instance of a serializedHTTPException.The reason this method should be added as part of the
HTTPExceptionAPI is because theHTTPExceptionis often serialized and transmitted over the wire to a different service. The client service which receives the serializedHTTPExceptionneeds a method to detect that the error payload is of shapeSerializedHTTPExceptionand not something else like a basic JavaScriptError. This is a very common use-case.Without this method, every client has to implement the duck-typing check for
SerializedHTTPExceptionto proper handle this exception. This creates duplication.Implementation details. How do you make this change?
Setup information
Deployment Notes
Related PRs
Checklist