Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Merged by Bors] - feat: add diagramID to diagram and program models (CV3-363) #451

Closed
wants to merge 1 commit into from
Closed

[Merged by Bors] - feat: add diagramID to diagram and program models (CV3-363) #451

wants to merge 1 commit into from

Conversation

viniciusdacal
Copy link
Contributor

Fixes or implements CV3-363

Brief description. What is this change?

  • add diagramID to diagram and program models. Moving forward, this field will be used as the canonical id for these entities.

Implementation details. How do you make this change?

Setup information

Deployment Notes

Related PRs

Checklist

  • Breaking changes have been communicated, including:
    • New required environment variables
    • Renaming of interfaces (API routes, request/response interface, etc)
  • New environment variables have been deployed
  • Appropriate tests have been written
    • Bug fixes are accompanied by an updated or new test
    • New features are accompanied by a new test

@viniciusdacal viniciusdacal self-assigned this Sep 8, 2023
@viniciusdacal
Copy link
Contributor Author

bors r+

bors-vf bot pushed a commit that referenced this pull request Sep 8, 2023
@viniciusdacal
feat: add diagramID to diagram and program models (CV3-363) (#451)
6a20f20 
<!-- You can erase any parts of this template not applicable to your Pull Request. -->

**Fixes or implements CV3-363**

### Brief description. What is this change?
 - add diagramID to diagram and program models. Moving forward, this field will be used as the canonical id for these entities.

<!-- Build up some context for your teammates on the changes made here and potential tradeoffs made and/or highlight any topics for discussion -->
@sonarcloud
Copy link

sonarcloud bot commented Sep 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

warning The version of Java (11.0.3) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bors-vf
Copy link

bors-vf bot commented Sep 8, 2023

Pull request successfully merged into master.

Build succeeded:

@bors-vf bors-vf bot changed the title feat: add diagramID to diagram and program models (CV3-363) [Merged by Bors] - feat: add diagramID to diagram and program models (CV3-363) Sep 8, 2023
@bors-vf bors-vf bot closed this Sep 8, 2023
@bors-vf bors-vf bot deleted the vinicius/add-diagram-id-to-diagram-and-program/CV3-363 branch September 8, 2023 20:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DecathectZero DecathectZero DecathectZero approved these changes

Assignees

@viniciusdacal viniciusdacal

Labels
ready for review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@viniciusdacal @DecathectZero