vcsim: add vslm VStorageObjectManager (aka FCD Global Catalog) support #3676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govc: make datastore (-ds flag) optional in (most) disk commands Fixes vmware#2542 Signed-off-by: Doug MacEachern <[email protected]>
akutz
approved these changes
Jan 14, 2025
| vslmtypes "github.com/vmware/govmomi/vslm/types" | ||
| ) | ||
|
|
||
| // Manager provides a layer for switching between Virtual Storage Object Manager (VSOM) |
There was a problem hiding this comment.
This is a really helpful comment, thanks @dougm !
| } | ||
|
|
||
| func (m *Manager) initGlobalManager(ctx context.Context) error { | ||
| if m.GlobalObjectManager == nil { |
There was a problem hiding this comment.
Should this use sync.Once anywhere?
There was a problem hiding this comment.
Might just get rid of this deferred initGlobalManager in the follow up to add metadata and query support. Instead will always create vslm.NewClient in NewManager, unless we're connected directly to ESX.
Also, only consumer of this disk.Manager is govc. I think most applications should directly just use vslm.Client against vCenter. Maybe we do the same in govc at some point and this Manager goes away completely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
govc: make datastore (-ds flag) optional in (most) disk commands
Fixes #2542