Bump golangci-lint from v1.57.2 to v1.63.4 #8641
Open
+82
−90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8641 +/- ##
==========================================
- Coverage 59.39% 59.39% -0.01%
==========================================
Files 370 370
Lines 39952 39953 +1
==========================================
Hits 23730 23730
- Misses 14731 14732 +1
Partials 1491 1491 ☔ View full report in Codecov by Sentry. |
mmorel-35
force-pushed
the
[email protected]
branch
from
825ba71 to
d04d8be
Compare
mmorel-35
force-pushed
the
[email protected]
branch
from
d04d8be to
de44870
Compare
|
/kind changelog-not-required |
github-actions
bot
added
the
kind/changelog-not-required
mmorel-35
force-pushed
the
[email protected]
branch
2 times, most recently
from
29874e2 to
312427f
Compare
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
[email protected]
branch
from
312427f to
7100c04
Compare
mmorel-35
commented
Jan 22, 2025
Comment on lines
515
to
523
| if test.dd.Namespace == velerov1api.DefaultNamespace { | ||
| if controllerutil.ContainsFinalizer(test.dd, DataUploadDownloadFinalizer) { | ||
| assert.True(t, true, apierrors.IsNotFound(err)) | ||
| assert.True(t, true, apierrors.IsNotFound(err)) //nolint:testifylint // TODO: Needs to be fixed | ||
| } else { | ||
| require.NoError(t, err) | ||
| } | ||
| } else { | ||
| assert.True(t, true, apierrors.IsNotFound(err)) | ||
| assert.True(t, true, apierrors.IsNotFound(err)) //nolint:testifylint // TODO: Needs to be fixed | ||
| } |
There was a problem hiding this comment.
@reasonerjt , @blackpiglet ,
This deserves your attention. I believe it deserves a dedicated PR outside this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Bump golangci-lint from v1.57.2 to v1.63.4 and fixes newly identified issues
Does your change fix a particular issue?
Fixes #(issue)
Please indicate you've done the following:
make new-changelog) or comment/kind changelog-not-requiredon this PR.site/content/docs/main.