Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable early-return and superfluous-else from revive #8640

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mmorel-35
Copy link
Contributor

@mmorel-35 mmorel-35 commented Jan 22, 2025

Thank you for contributing to Velero!

Please add a summary of your change

enables and fixes early-return and superfluous-else from revive

Does your change fix a particular issue?

Fixes #(issue)

Please indicate you've done the following:

@mmorel-35
Copy link
Contributor Author

/kind changelog-not-required

@github-actions github-actions bot added the kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes label Jan 22, 2025
@mmorel-35 mmorel-35 force-pushed the revive/superfluous-else branch from 43abdfa to 76702e6 Compare January 22, 2025 16:03
@mmorel-35 mmorel-35 force-pushed the revive/superfluous-else branch from 76702e6 to f01c93f Compare January 22, 2025 18:11
Copy link

codecov bot commented Jan 22, 2025

Codecov Report

Attention: Patch coverage is 90.47619% with 14 lines in your changes missing coverage. Please review.

Project coverage is 59.39%. Comparing base (a9031eb) to head (f01c93f).

Files with missing lines Patch % Lines
internal/volume/volumes_information.go 92.74% 7 Missing and 2 partials ⚠️
pkg/uploader/kopia/block_restore.go 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8640      +/-   ##
==========================================
- Coverage   59.39%   59.39%   -0.01%     
==========================================
  Files         370      370              
  Lines       39952    39945       -7     
==========================================
- Hits        23730    23724       -6     
+ Misses      14731    14728       -3     
- Partials     1491     1493       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-e2e-2tests has-unit-tests kind/changelog-not-required PR does not require a user changelog. Often for docs, website, or build changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant