Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

velero: ensure that the plugin is installed #382

Open
wants to merge 17 commits into
base: main
Choose a base branch
from

Conversation

omichels
Copy link

@omichels omichels commented Jun 15, 2022

Special notes for your reviewer:

Checklist

[Place an '[x]' (no spaces) in all applicable fields. Please remove unrelated fields.]

  • DCO signed
  • Chart Version bumped
  • Variables are documented in the values.yaml or README.md
  • Title of the PR starts with chart name (e.g. [velero])

@jenting
Copy link
Collaborator

jenting commented Jun 17, 2022

Thanks to your contribution, however, it means we need to handle the plug-ins version as well.

If you were installing with the correct command, the issue isn't exist, correct?

@jenting jenting added the velero label Jun 19, 2022
omichels and others added 14 commits July 13, 2022 08:45
Signed-off-by: Scott Seago <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: JenTing Hsiao <[email protected]>
Signed-off-by: Oliver Michels <[email protected]>
@jenting
Copy link
Collaborator

jenting commented Aug 1, 2022

Correct me if I'm wrong, but I still think this PR doesn't need it.
If you were installing with the correct command, the issue doesn't exist, correct?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants