This repository has been archived by the owner on Mar 15, 2021. It is now read-only.
Wavefront, Influx, OpenTSDB DCC and packages for wavefront, influx, opentsdb. #184
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KohliDev
requested review from
GregBollella,
arunnswamy,
pmasrani and
winniex1
|
@Venkat2811 Please review the code. |
Venkat2811
suggested changes
Nov 23, 2017
| else: | ||
| host = (reg_metric.parent).ref_entity.entity_id #if device is not available, only gateway uuid | ||
|
|
||
| metric_unit = str(reg_metric.ref_entity.unit) |
There was a problem hiding this comment.
Parse unit is available in si_unit.py. Please use that.
| else: | ||
| host = (reg_metric.parent).ref_entity.entity_id #if device is not available, only gateway uuid | ||
|
|
||
| metric_unit = str(reg_metric.ref_entity.unit) |
There was a problem hiding this comment.
Parse unit is available in si_unit.py. Please use that.
|
|
||
| def _format_data(self, reg_metric): | ||
| met_cnt = reg_metric.values.qsize() | ||
| message = '' |
There was a problem hiding this comment.
Create these variables after met_cnt validation
|
|
||
| def _format_data(self, reg_metric): | ||
| met_cnt = reg_metric.values.qsize() | ||
| message = '' |
There was a problem hiding this comment.
Create these variables after met_cnt validation
|
|
||
| def _format_data(self, reg_metric): | ||
| met_cnt = reg_metric.values.qsize() | ||
| message = '' |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added wavefront, influx, opentsdb DCCs and packages for wavefront, influx, opentsdb along with them examples for the DCCs.