Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bring back IDisposable to the UnitOfWork #9

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

seanalexander
Copy link
Contributor

Used code from "\After" for IDisposable.

Verified the application was still functional.

Verified Performance is still acceptable:
image

Verified there were no open queries during this test using sp_WhoIsActive.

@vkhorikov
Copy link
Owner

vkhorikov commented Dec 23, 2019

The Dispose() method should come with a using around UnitOfWork in each command handler, otherwise it'd leak connections too.

@seanalexander
Copy link
Contributor Author

I'll update that and repost--I re-used the example from what was in \After

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants