Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for VIVO-4010 #474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

litvinovg
Copy link
Contributor

VIVO GitHub issue

  • Other Relevant Links (Mailing list discussion, related pull requests, etc.)

What does this pull request do?

Fixes autocompletion text

How should this be tested?

A description of what steps someone could take to:

  • Reproduce the problem in the issue
  • Test that the pull request resolves the issue

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:

  1. JavaScript

Reviewers' report template

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

@litvinovg litvinovg linked an issue Sep 24, 2024 that may be closed by this pull request
@chenejac chenejac self-requested a review September 24, 2024 14:31
Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Testing

This is working stochastic for me, i.e. when I am typing in the Subject Area (when trying to define advisor relationship) some person last name at some moment the list of offered Subject Areas include persons and when continue typing only Subject Areas appear. So, I didn't try just to copy some text in the field, I tried really to type and the issue is still there occasionally.

@litvinovg
Copy link
Contributor Author

Testing

This is working stochastic for me, i.e. when I am typing in the Subject Area (when trying to define advisor relationship) some person last name at some moment the list of offered Subject Areas include persons and when continue typing only Subject Areas appear. So, I didn't try just to copy some text in the field, I tried really to type and the issue is still there occasionally.

That's what I see without this PR applied. I can't reproduce it with applied PR.
Did you use mvn clean install?
Could you provide more information to reproduce it?

Copy link
Contributor

@chenejac chenejac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@litvinovg thanks for this. The PR is fixing the issue. No complaints on the code. Well done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong results in entry forms autocompletion
3 participants