Fix for container conversions in JsonConverter #417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ways return empty string for container nodes
chenejac
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
@litvinovg thanks. Hopefully, after this fix, serialization of nodes wouldn't cause any issue.
mmannings
approved these changes
Aug 30, 2023
There was a problem hiding this comment.
Fixes the exception:
"Json string cannot be null", when sending the GET request on /api/rest/1/report_generator/resource:{resource_id}
Thanks @litvinovg
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this pull request do?
Fixes Json converter conversion of json arrays and json objects.
Recently added fix to use node.asText() for node serialization doesn't work for json containers as asText() always return "" for containers.
Interested parties
@chenejac @ivanmrsulja @mmannings