Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple installation and deployment #4017

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

litvinovg
Copy link
Collaborator

@litvinovg litvinovg commented Oct 23, 2024

VIVO GitHub issue
Vitro PR

What does this pull request do?

Decoupled deployment and installation processes
Changed delivery of home directory: package it's contents as part of war artifact, update default files on home directory except rdf subdirectory on startup.
In case tomcat directory is not provided artifact will not be copied into tomcat webapps directory

What's new?

Changed deployment: war artifact is copied into webapp directory, not unpacked
Home directory contents are copied into war artifact
On startup path to home directory is being created if not already exists.
RDFFilesLoader and FileGraphSetup were adjusted to read rdf contents from tomcat webapp application directory

How should this be tested?

Test update of already installed instance and installation of new instance.

  • Try standard installation method mvn install -s example-settings.xml
  • Remove tomcat directory from xml file, copy created war file manually to tomcat webapp directory, that should result in deployment of application.

Additional Notes:

This change require documentation to be updated

Interested parties

@VIVO-project/vivo-committers

Reviewers' expertise

Candidates for reviewing this PR should have some of the following expertises:
2. Maven

Reviewers' report template

Please update the following template which should be used by reviewers.

General comment

A reviewer should provide here comments and suggestions for requested changes if any.

Testing

A reviewer should briefly describe here how it was tested

Code reviewing

A reviewer should briefly describe here which part was code reviewed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VIVO-1443: Decouple VIVO build from installation
1 participant