Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Infrastructure improvements - Migration to Java 11 from Java 8 #3836

Draft
wants to merge 14 commits into
base: jena4-upgrade
Choose a base branch
from
Draft

Infrastructure improvements - Migration to Java 11 from Java 8 #3836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
bc76f38
Change project.version to 1.14.1-SNAPSHOT
michel-heon Feb 22, 2023
a7f21fc
Adding an echo mechanism for maven properties
michel-heon Feb 22, 2023
5acba05
Replacing
michel-heon Feb 22, 2023
28ad9db
Update pom.xml
michel-heon Feb 25, 2023
e9ba32a
Update pom.xml
michel-heon Feb 25, 2023
612a410
Update pom.xml
michel-heon Feb 25, 2023
8ed6385
Update pom.xml
michel-heon Feb 25, 2023
d522f63
Update pom.xml
michel-heon Feb 25, 2023
4efce05
Update pom.xml
michel-heon Feb 25, 2023
ad83d94
Update pom.xml
michel-heon Feb 25, 2023
1a877a2
Update pom.xml
michel-heon Feb 25, 2023
b3e301a
Removing the properties trace (echoing messages) used by Maven
michel-heon Feb 27, 2023
e9428f6
Added configuration for enforcer and updated enforcer-version to (3.2.1)
michel-heon Feb 27, 2023
c71ae4d
Remove Maven rules in enforcer
michel-heon Mar 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion home/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,4 +69,4 @@
<type>tar.gz</type>
</dependency>
</dependencies>
</project>
</project>
22 changes: 14 additions & 8 deletions installer/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,6 @@
<plugin>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
<target>1.8</target>
<encoding>UTF-8</encoding>
</configuration>
</plugin>
Expand Down Expand Up @@ -72,8 +70,8 @@
</plugin>
<plugin>
<artifactId>maven-enforcer-plugin</artifactId>
<version>1.4.1</version>
</plugin>
<version>3.2.1</version>
</plugin>
Comment on lines +73 to +74
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<version>3.2.1</version>
</plugin>
<version>1.4.1</version>
</plugin>

Copy link
Member Author

@michel-heon michel-heon Mar 2, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chenejac
I don't think it's a good idea to go back to 1.4.1,
This version 1.4.1 doesn't handle the message presentation very well, which makes it very irrelevant to use this utility.
Moreover, if we go back to 1.4.1 we will also have to change VIVO.

Is it really a blocker to use more up-to-date plug-ins?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most likely it will impose new dependencies on maven or other components. I wouldn't change maven enforcer version in this PR.

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
Expand Down Expand Up @@ -127,7 +125,9 @@
<profile>
<id>skip-install</id>
<activation>
<property><name>!vivo-dir</name></property>
<property>
<name>!vivo-dir</name>
</property>
</activation>
<build>
<plugins>
Expand Down Expand Up @@ -175,7 +175,7 @@
<executions>
<execution>
<id>test</id>
<phase/>
<phase />
</execution>
</executions>
</plugin>
Expand All @@ -184,7 +184,7 @@
<executions>
<execution>
<id>default-war</id>
<phase/>
<phase />
</execution>
</executions>
</plugin>
Expand All @@ -194,7 +194,9 @@
<profile>
<id>install</id>
<activation>
<property><name>vivo-dir</name></property>
<property>
<name>vivo-dir</name>
</property>
</activation>
<build>
<plugins>
Expand All @@ -213,6 +215,10 @@
<property>app-name</property>
<message>You must provide an application name (app-name)</message>
</requireProperty>
<requireJavaVersion>
<version>11</version>
<message>Invalid Java version. It should, at least, be 11</message>
</requireJavaVersion>
</rules>
</configuration>
</execution>
Expand Down
5 changes: 3 additions & 2 deletions pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
<maven-site-plugin.skip>false</maven-site-plugin.skip>
<stagingBase>/</stagingBase>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<maven.compiler.release>11</maven.compiler.release>
</properties>

<modules>
Expand Down Expand Up @@ -297,14 +298,14 @@
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<source>1.8</source>
<target>1.8</target>
<encoding>UTF-8</encoding>
<compilerArgs>
<arg>-XDcompilePolicy=simple</arg>
</compilerArgs>
</configuration>
</plugin>


<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>buildnumber-maven-plugin</artifactId>
Expand Down