Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Properly set timing window values for easier difficulties #74

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Properly set timing window values for easier difficulties #74

merged 2 commits into from
Apr 29, 2024

Conversation

vivaria
Copy link
Owner

@vivaria vivaria commented Apr 29, 2024 •
edited
Loading

Adding failing test first, then adding fix after (should fix error)

Fixes #73.

@vivaria vivaria added the bug Something isn't working label Apr 29, 2024
@vivaria vivaria self-assigned this Apr 29, 2024
@vivaria vivaria merged commit 405cea3 into main Apr 29, 2024
2 checks passed
@vivaria vivaria deleted the viv/73-fix-timing-windows branch April 29, 2024 22:44
@vivaria vivaria mentioned this pull request Apr 30, 2024
Merged
vivaria added a commit that referenced this pull request Apr 30, 2024
@vivaria
Allow tja2fumen to be run on folders to allow fixing timing windows…
0dc3452 
… on all .bin files (#75)

This saves the need for users running an extra script to call tja2fumen
once per file

This is especially important for the fix in #74.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vivaria vivaria

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timing windows are incorrect for easier difficulties
1 participant
@vivaria