[TASK] Remove rename side effect #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
megamisan
force-pushed
the
remove-rename-side-effect
branch
3 times, most recently
from
b35ce76 to
90e95a0
Compare
Changes renames on build start and end to custom id resolver and load
megamisan
force-pushed
the
remove-rename-side-effect
branch
from
90e95a0 to
2cb4132
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using an external watcher or using the watch mode from vite, the side-effect of renaming file on build start and back on build end triggers a new run indefinitly.
This change removes the renaming and tries to resolve the original file name when it detects an html file following the renaming pattern. It delegates the resolution back to vite and especially vite:resolver which originaly handled the resolution.
It also handles the file content loading as it is no more handled by vite:load-fallback, using the real file name instead of module id if known.
Remark: It can be applied to the other templating plugins.