Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go/vt/mysqlctl: add postflight_mysqld_start and preflight_mysqld_shutdown hooks #17652

Merged
merged 2 commits into from
Jan 30, 2025

Conversation

maxenglander
Copy link
Collaborator

@maxenglander maxenglander commented Jan 29, 2025

Description

Add postflight_mysqld_start and preflight_mysqld_shutdown hooks. This will allow users to take some action after Vitess starts mysqld, and before it is about to shut it down, all while allowing Vitess keep responsibility for actually starting/stopping mysqld.

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

None.

@github-actions github-actions bot added this to the v22.0.0 milestone Jan 29, 2025
Copy link
Contributor

vitess-bot bot commented Jan 29, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 29, 2025
@maxenglander maxenglander added the Type: Enhancement Logical improvement (somewhere between a bug and feature) label Jan 29, 2025
Copy link

codecov bot commented Jan 29, 2025

Codecov Report

Attention: Patch coverage is 0% with 13 lines in your changes missing coverage. Please review.

Project coverage is 67.75%. Comparing base (fd1186c) to head (3a9089a).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/mysqlctl/mysqld.go 0.00% 13 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #17652   +/-   ##
=======================================
  Coverage   67.75%   67.75%           
=======================================
  Files        1586     1586           
  Lines      255726   255775   +49     
=======================================
+ Hits       173261   173308   +47     
- Misses      82465    82467    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maxenglander maxenglander changed the title go/vt/mysqlctl: add preflight_mysqld_shutdown hook go/vt/mysqlctl: add postflight_mysqld_start and preflight_mysqld_shutdown hooks Jan 29, 2025
@mattlord mattlord added Component: Cluster management and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsWebsiteDocsUpdate What it says labels Jan 29, 2025
@deepthi deepthi merged commit f7ea3a3 into main Jan 30, 2025
202 of 206 checks passed
@deepthi deepthi deleted the maxeng-preflight-mysqld-shutdown branch January 30, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Cluster management Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: add support for mysqld pre-shutdown and post-start hooks
4 participants