-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
go/vt/mysqlctl: add postflight_mysqld_start and preflight_mysqld_shutdown hooks #17652
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max Englander <[email protected]>
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Jan 29, 2025
maxenglander
added
the
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
label
Jan 29, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #17652 +/- ##
=======================================
Coverage 67.75% 67.75%
=======================================
Files 1586 1586
Lines 255726 255775 +49
=======================================
+ Hits 173261 173308 +47
- Misses 82465 82467 +2 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Max Englander <[email protected]>
maxenglander
changed the title
go/vt/mysqlctl: add preflight_mysqld_shutdown hook
go/vt/mysqlctl: add postflight_mysqld_start and preflight_mysqld_shutdown hooks
Jan 29, 2025
mattlord
added
Component: Cluster management
and removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsBackportReason
If backport labels have been applied to a PR, a justification is required
NeedsWebsiteDocsUpdate
What it says
labels
Jan 29, 2025
mattlord
approved these changes
Jan 29, 2025
dbussink
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Cluster management
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
postflight_mysqld_start
andpreflight_mysqld_shutdown
hooks. This will allow users to take some action after Vitess startsmysqld
, and before it is about to shut it down, all while allowing Vitess keep responsibility for actually starting/stoppingmysqld
.Related Issue(s)
Checklist
Deployment Notes
None.