Refactor Disk Stall implementation and mark tablet not serving if disk is stalled

[GuptaManan100]

Description

After reading up the feature request #17610, I looked at the implementation of disk stall monitor added in #17470 and how we could use that to address this request.

As stated in #17610 (comment), I changed the code to now make the vttablet broadcast itself as non-serving if the disk is stalled. This would prevent the vtgate from sending queries to this tablet until the disk has recovered.

While at this change, I also refactored how disk stall information was communicated in the full status output. In the original PR I had a comment #16050 (comment) requesting to not use the error as a means of communication in the FullStatus RPC. I forgot to address this comment when I revived the PR. I have made the change in this PR, and introduced a new field in the full status result.

Since the changes haven't gone into a released version of vitess, we don't need to worry about backward compatibility for this refactor.

Related Issue(s)

• Closes Feature Request: vtgate handles replicas with stalled disk #17610

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

Deployment Notes

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[timvaillancourt]

I was going to propose the same change, great!

[timvaillancourt]

LGTM 👍

[codecov]

Codecov Report

Attention: Patch coverage is 42.85714% with 12 lines in your changes missing coverage. Please review.

Project coverage is 67.61%. Comparing base (a6c2896) to head (130f090).

Files with missing lines	Patch %	Lines
go/vt/vttablet/tabletmanager/rpc_replication.go	0.00%	4 Missing ⚠️
go/vt/vtorc/inst/instance_dao.go	0.00%	3 Missing ⚠️
go/vt/vttablet/tabletservermock/controller.go	0.00%	3 Missing ⚠️
go/vt/vttablet/tabletserver/tabletserver.go	33.33%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17624      +/-   ##
==========================================
- Coverage   67.64%   67.61%   -0.03%     
==========================================
  Files        1586     1586              
  Lines      255629   255640      +11     
==========================================
- Hits       172910   172858      -52     
- Misses      82719    82782      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.