Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VReplication: Address SwitchWrites bugs around replication lag and cancel on error #17616

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

VReplication: Address SwitchWrites bugs around replication lag and cancel on error #17616

wants to merge 7 commits into from
+144 −35

Conversation

mattlord
Copy link
Contributor

@mattlord mattlord commented Jan 23, 2025 •
edited
Loading

Description

Related Issue(s)

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jan 23, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 23, 2025
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 23, 2025
@mattlord
Add e2e test
4e8e109 
Signed-off-by: Matt Lord <[email protected]>
@mattlord mattlord added Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 and removed NeedsWebsiteDocsUpdate What it says labels Jan 23, 2025
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 70.00000% with 9 lines in your changes missing coverage. Please review.

Project coverage is 67.66%. Comparing base (99856a2) to head (3964c7c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
go/vt/vtctl/workflow/workflows.go 83.33% 4 Missing ⚠️
go/vt/vtctl/workflow/traffic_switcher.go 0.00% 3 Missing ⚠️
go/vt/vtctl/workflow/server.go 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #17616      +/-   ##
==========================================
- Coverage   67.69%   67.66%   -0.03%     
==========================================
  Files        1586     1586              
  Lines      255403   255407       +4     
==========================================
- Hits       172883   172826      -57     
- Misses      82520    82581      +61

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattlord
Use trx lag
9fb48f7 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Improve comments
433d7ff 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
Nitty var name change
a7f400c 
Signed-off-by: Matt Lord <[email protected]>
@mattlord
More nits
3964c7c 
Signed-off-by: Matt Lord <[email protected]>
rohit-nayak-ps
rohit-nayak-ps reviewed Jan 23, 2025
View reviewed changes
go/vt/vtctl/workflow/workflows.go
updatedTs = &vttimepb.Time{}
}
lastUpdateTime := updatedTs.Seconds
if state == binlogdatapb.VReplicationWorkflowState_Copying {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe worth returning maxint for any state other than Running

go/test/endtoend/vreplication/vreplication_test.go
// Confirm that switching writes works as expected in the face of
// vreplication lag (canSwitch() precheck) and when cancelling the
// switch due to replication failing to catch up in time.
t.Run("validate switch writes error handling", func(t *testing.T) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's extract this into a separate method.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohit-nayak-ps rohit-nayak-ps rohit-nayak-ps left review comments

@notfelineit notfelineit notfelineit approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi will be requested when the pull request is marked ready for review deepthi is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
Backport to: release-19.0 Needs to be back ported to release-19.0 Backport to: release-20.0 Needs to be backport to release-20.0 Backport to: release-21.0 Needs to be backport to release-21.0 NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request
Projects
None yet
Milestone
v22.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@mattlord @notfelineit @rohit-nayak-ps