Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release-20.0] Tablet picker: Handle the case where a primary tablet is not setup for a shard (#17573) #17575

Merged
merged 2 commits into from
Jan 19, 2025

Trigger rebuild

f9bcfe5
Select commit
Loading
Failed to load commit list.
Merged

[release-20.0] Tablet picker: Handle the case where a primary tablet is not setup for a shard (#17573) #17575

Trigger rebuild
f9bcfe5
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 19, 2025 in 1s

66.43% (+0.01%) compared to be08a65

View this Pull Request on Codecov

66.43% (+0.01%) compared to be08a65

Details

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 66.43%. Comparing base (be08a65) to head (f9bcfe5).

Files with missing lines Patch % Lines
go/vt/topo/tablet.go 33.33% 2 Missing ⚠️
go/vt/discovery/tablet_picker.go 83.33% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff                @@
##           release-20.0   #17575      +/-   ##
================================================
+ Coverage         66.41%   66.43%   +0.01%     
================================================
  Files              1541     1541              
  Lines            244116   244122       +6     
================================================
+ Hits             162137   162182      +45     
+ Misses            81979    81940      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.