VDiff: Remove extra % sign in vdiff text report template

[mattlord]

Description

The text template used for VDiff reports had an extraneous % sign in it (needed for printf, but NOT templates):

vitess/go/cmd/vtctldclient/command/vreplication/vdiff/vdiff.go

Line 439 in eaaa206

{{if (eq .State "started")}}Progress: {{printf "%.2f" .Progress.Percentage}}%%{{if .Progress.ETA}}, ETA: {{.Progress.ETA}}{{end}}{{end}}

I would notice this every once in a while, but then forget about it. I'm finally cleaning that up here. 🙂

Manual test :

cd examples/local

./101_initial_cluster.sh && mysql < ../common/insert_commerce_data.sql && ./201_customer_tablets.sh

table_file="${VTDATAROOT}/vt_0000000100/data/vt_commerce/customer.ibd"
commerce_primary_uid=$(vtctldclient GetTablets --keyspace commerce --tablet-type primary --shard "0" | awk '{print $1}' | cut -d- -f2 | bc)

# Generate 5MiB of initial data
size=$((5*1024*1024))
while [[ $(stat -f "%z" "${table_file}") -lt ${size} ]]; do
    command mysql -u root --socket "${VTDATAROOT}/vt_0000000${commerce_primary_uid}/mysql.sock" vt_commerce -e "insert into customer (customer_id, email) values (${RANDOM}*${RANDOM}, '${RANDOM}[email protected]')" 2> /dev/null
done

# Get us up to 64MiB of data
size=$((64*1024*1024))
i=1
while [[ $(stat -f "%z" "${table_file}") -lt ${size} ]]; do
    command mysql -u root --socket "${VTDATAROOT}/vt_0000000${commerce_primary_uid}/mysql.sock" vt_commerce -e "insert into customer (email) select concat(${i}, email) from customer limit 5000000"
    let i=i+1
done

./202_move_tables.sh

vtctldclient vdiff --target-keyspace customer --workflow commerce2customer create --max-diff-duration 1s --auto-retry=false --update-table-stats

❯ vtctldclient vdiff --target-keyspace customer --workflow commerce2customer show last

VDiff Summary for customer.commerce2customer (17605a53-0055-4f88-9335-5ff24fc61be8)
State:        started
RowsCompared: 644217
HasMismatch:  false
StartedAt:    2025-01-18 21:06:26
Progress:     38.38%, ETA: 2025-01-18 21:06:28

Use "--format=json" for more detailed output.

Related Issue(s)

Checklist

• "Backport to:" labels have been added if this change should be back-ported to release branches
• If this change is to be back-ported to previous releases, a justification is included in the PR description
• Tests were added or are not required
• Did the new or modified tests pass consistently locally and on CI?
• Documentation was added or is not required

[vitess-bot]

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

• Ensure that the Pull Request has a descriptive title.
• Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

• Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

• Apply the release notes (needs details) label if users need to know about this change.
• New features should be documented.
• There should be some code comments as to why things are implemented the way they are.
• There should be a comment at the top of each new or modified test to explain what the test does.

New flags

• Is this flag really necessary?
• Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

• Each item in Jobs should be named in order to mark it as required.
• If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

• Protobuf changes should be wire-compatible.
• Changes to _vt tables and RPCs need to be backward compatible.
• RPC changes should be compatible with vitess-operator
• If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
• vtctl command output order should be stable and awk-able.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.70%. Comparing base (71ccd6d) to head (aee5d0e).
Report is 3 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #17568      +/-   ##
==========================================
- Coverage   67.71%   67.70%   -0.01%     
==========================================
  Files        1584     1585       +1     
  Lines      254721   254818      +97     
==========================================
+ Hits       172473   172526      +53     
- Misses      82248    82292      +44     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.