Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
+3,075 −528
Open

LookupVindex: Multiple lookup tables support for LookupVindexCreate #17566

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c9e74bf
LookupVindex: Multiple lookup tables support for LookupVindexCreate
beingnoble03 Jan 17, 2025
af6c741
test: Fix failing unit tests
beingnoble03 Jan 17, 2025
86d4cd9
Remove unnecessary code
beingnoble03 Jan 20, 2025
9133e84
Clean code and abstract into common functions
beingnoble03 Jan 28, 2025
fcb540b
Merge main into lv-multiple-tables
beingnoble03 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 1 addition & 15 deletions go/vt/vtctl/workflow/materializer_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2541,20 +2541,6 @@ func TestCreateLookupVindexFailures(t *testing.T) {
schemaAdditions []*tabletmanagerdatapb.TableDefinition
err string
}{
{
description: "dup vindex",
input: &vschemapb.Keyspace{
Vindexes: map[string]*vschemapb.Vindex{
"v1": {
Type: "xxhash",
},
"v2": {
Type: "xxhash",
},
},
},
err: "only one vindex must be specified",
Comment on lines -2595 to -2607
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we will support backfilling multiple lookup tables, this unit test can be removed.

},
{
description: "not a lookup",
input: &vschemapb.Keyspace{
Expand Down Expand Up @@ -2633,7 +2619,7 @@ func TestCreateLookupVindexFailures(t *testing.T) {
input: &vschemapb.Keyspace{
Vindexes: unique,
},
err: "one or two tables must be specified",
err: "atleast one table must be specified",
},
{
description: "too many tables",
Expand Down
Loading