Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bundled MySQL version to 8.0.40 #17552

Merged
merged 9 commits into from
Jan 21, 2025

Conversation

dbussink
Copy link
Contributor

We haven't updated the bundled MySQL version in a while and it also blocks us from upgrading our base Debian version for the containers we build as well.

So update to the latest 8.0.x version here. It's also at least version 8.0.35, which means that updates after this one are going to be much easier as upgrades / downgrades between different patch versions are possible for 8.0.35 and later.

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Copy link
Contributor

vitess-bot bot commented Jan 16, 2025

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jan 16, 2025
@dbussink dbussink force-pushed the dbussink/update-mysql-8-0-40 branch from 9e82bb4 to 220dcfd Compare January 16, 2025 08:57
@github-actions github-actions bot added this to the v22.0.0 milestone Jan 16, 2025
@dbussink dbussink mentioned this pull request Jan 16, 2025
5 tasks
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jan 16, 2025
Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.69%. Comparing base (4687195) to head (0e60aa0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17552      +/-   ##
==========================================
- Coverage   67.70%   67.69%   -0.01%     
==========================================
  Files        1585     1585              
  Lines      254833   254833              
==========================================
- Hits       172524   172506      -18     
- Misses      82309    82327      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GrahamCampbell
Copy link
Contributor

I've created planetscale/vitess-operator#653 which applies upgrades to the operator. Feel free to throw it away if you had other plans. ;)

Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also update this:
examples/operator/101_initial_cluster.yaml: mysql80Compatible: mysql:8.0.30

@frouioui are you already coordinating with @dbussink on this? As you both know, it will span many PRs across several repos 🙂 Let me know if you could use any help.

changelog/22.0/22.0.0/summary.md Outdated Show resolved Hide resolved
@dbussink dbussink force-pushed the dbussink/update-mysql-8-0-40 branch from 220dcfd to ac6e0f3 Compare January 20, 2025 08:56
@dbussink
Copy link
Contributor Author

We should also update this:
examples/operator/101_initial_cluster.yaml: mysql80Compatible: mysql:8.0.30

Fixed!

@dbussink
Copy link
Contributor Author

@frouioui are you already coordinating with @dbussink on this? As you both know, it will span many PRs across several repos 🙂 Let me know if you could use any help.

@mattlord @frouioui Apart from the operator already referenced here, what other repos are involved?

@dbussink dbussink removed NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Jan 20, 2025
Comment on lines 158 to 164
### Changes
- Update base image to bookworm
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we are changing the bootstrap version, we need to bump the version we use everywhere 39 to 40. For instance in the Makefile we have BOOTSTRAP_VERSION=39 which must be changed. Same thing in test.go and other places.

Copy link
Member

@frouioui frouioui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you @dbussink

@frouioui
Copy link
Member

#17563 is bumping the bootstrap version to 40. The bootstrap version on this PR must be updated to 41.

dbussink and others added 8 commits January 20, 2025 21:58
We haven't updated the bundled MySQL version in a while and it also
blocks us from upgrading our base Debian version for the containers we
build as well.

So update to the latest 8.0.x version here. It's also at least version
8.0.35, which means that updates after this one are going to be much
easier as upgrades / downgrades between different patch versions are
possible for 8.0.35 and later.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Bullseye is already in the LTS phase, so we really should upgrade to
bookworm here.

Signed-off-by: Dirkjan Bussink <[email protected]>
MySQL 8.0.40 is no longer published for Debian Bullseye, so we gotta
update these together.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
@dbussink dbussink force-pushed the dbussink/update-mysql-8-0-40 branch from 7cb8740 to 0df00ef Compare January 20, 2025 21:01
Copy link
Member

@GuptaManan100 GuptaManan100 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@harshit-gangal harshit-gangal force-pushed the dbussink/update-mysql-8-0-40 branch from b83a940 to 0e60aa0 Compare January 21, 2025 09:28
@dbussink dbussink merged commit 9b57daf into vitessio:main Jan 21, 2025
103 checks passed
@dbussink dbussink deleted the dbussink/update-mysql-8-0-40 branch January 21, 2025 09:58
@dbussink dbussink mentioned this pull request Jan 21, 2025
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants