-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update bundled MySQL version to 8.0.40 #17552
Update bundled MySQL version to 8.0.40 #17552
Conversation
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
9e82bb4
to
220dcfd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #17552 +/- ##
==========================================
- Coverage 67.70% 67.69% -0.01%
==========================================
Files 1585 1585
Lines 254833 254833
==========================================
- Hits 172524 172506 -18
- Misses 82309 82327 +18 ☔ View full report in Codecov by Sentry. |
I've created planetscale/vitess-operator#653 which applies upgrades to the operator. Feel free to throw it away if you had other plans. ;) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
220dcfd
to
ac6e0f3
Compare
Fixed! |
docker/bootstrap/CHANGELOG.md
Outdated
### Changes | ||
- Update base image to bookworm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since we are changing the bootstrap version, we need to bump the version we use everywhere 39
to 40
. For instance in the Makefile we have BOOTSTRAP_VERSION=39
which must be changed. Same thing in test.go
and other places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you @dbussink
#17563 is bumping the bootstrap version to |
We haven't updated the bundled MySQL version in a while and it also blocks us from upgrading our base Debian version for the containers we build as well. So update to the latest 8.0.x version here. It's also at least version 8.0.35, which means that updates after this one are going to be much easier as upgrades / downgrades between different patch versions are possible for 8.0.35 and later. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Bullseye is already in the LTS phase, so we really should upgrade to bookworm here. Signed-off-by: Dirkjan Bussink <[email protected]>
MySQL 8.0.40 is no longer published for Debian Bullseye, so we gotta update these together. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Florent Poinsard <[email protected]>
7cb8740
to
0df00ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Harshit Gangal <[email protected]>
b83a940
to
0e60aa0
Compare
We haven't updated the bundled MySQL version in a while and it also blocks us from upgrading our base Debian version for the containers we build as well.
So update to the latest 8.0.x version here. It's also at least version 8.0.35, which means that updates after this one are going to be much easier as upgrades / downgrades between different patch versions are possible for 8.0.35 and later.
Checklist