Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VReplication: handle escaped identifiers in vschema when initializing sequence tables #16169

Merged
merged 11 commits into from
Jun 18, 2024

Correct variable names and cover errors in unit test

990cc6a
Select commit
Loading
Failed to load commit list.
Merged

VReplication: handle escaped identifiers in vschema when initializing sequence tables #16169

Correct variable names and cover errors in unit test
990cc6a
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jun 16, 2024 in 1s

68.59% (+0.01%) compared to 13846e6

View this Pull Request on Codecov

68.59% (+0.01%) compared to 13846e6

Details

Codecov Report

Attention: Patch coverage is 49.36709% with 40 lines in your changes missing coverage. Please review.

Project coverage is 68.59%. Comparing base (13846e6) to head (990cc6a).
Report is 2 commits behind head on main.

Files Patch % Lines
go/vt/vtctl/workflow/traffic_switcher.go 50.00% 39 Missing ⚠️
go/vt/vttablet/tabletserver/schema/engine.go 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16169      +/-   ##
==========================================
+ Coverage   68.57%   68.59%   +0.01%     
==========================================
  Files        1544     1544              
  Lines      197863   197918      +55     
==========================================
+ Hits       135688   135757      +69     
+ Misses      62175    62161      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.