Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker: Update node vtadmin version #16147

Merged
merged 2 commits into from
Jun 13, 2024
Merged

Docker: Update node vtadmin version #16147

merged 2 commits into from
Jun 13, 2024

Conversation

shlomi-noach
Copy link
Contributor

Description

One of the vtadmin packages requires node 20 (otherwise docker builds fail).
This is a reverse backport from #16145

  • To be backported to release-20.0.
  • No need to backport to release-20.0-rc because it already contains this fix.

Related Issue(s)

#16010

Checklist

  • "Backport to:" labels have been added if this change should be back-ported to release branches
  • If this change is to be back-ported to previous releases, a justification is included in the PR description
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on CI?
  • Documentation was added or is not required

Deployment Notes

@shlomi-noach
update node setup
0a2679e 
Signed-off-by: Shlomi Noach <[email protected]>
@shlomi-noach
Docker/vtadmin: Update node version
e30c763 
Signed-off-by: Shlomi Noach <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Jun 13, 2024

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsBackportReason If backport labels have been applied to a PR, a justification is required NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Jun 13, 2024
@shlomi-noach shlomi-noach removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request NeedsBackportReason If backport labels have been applied to a PR, a justification is required labels Jun 13, 2024
@github-actions github-actions bot added this to the v21.0.0 milestone Jun 13, 2024
@frouioui frouioui merged commit e9bdc39 into vitessio:main Jun 13, 2024
106 checks passed
@frouioui frouioui deleted the update-docker-node-vtadmin-version branch June 13, 2024 15:00
vitess-bot pushed a commit that referenced this pull request Jun 13, 2024
@vitess-bot
Docker: Update node vtadmin version (#16147)
10b08fd 
Signed-off-by: Shlomi Noach <[email protected]>
@vitess-bot vitess-bot bot mentioned this pull request Jun 13, 2024
Merged
frouioui pushed a commit that referenced this pull request Jun 13, 2024
@vitess-bot
[release-20.0] Docker: Update node vtadmin version (#16147) (#16161)
545e69d 
Signed-off-by: Shlomi Noach <[email protected]>
Co-authored-by: vitess-bot[bot] <108069721+vitess-bot[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frouioui frouioui frouioui approved these changes

@dbussink dbussink dbussink approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

@derekperkins derekperkins Awaiting requested review from derekperkins derekperkins is a code owner

@mattlord mattlord Awaiting requested review from mattlord mattlord is a code owner

@GuptaManan100 GuptaManan100 Awaiting requested review from GuptaManan100 GuptaManan100 is a code owner

Assignees
No one assigned
Labels
Backport to: release-20.0 Needs to be backport to release-20.0 Component: Docker Component: VTAdmin VTadmin interface Type: CI/Build
Projects
None yet
Milestone
v21.0.0
Development

Successfully merging this pull request may close these issues.
3 participants
@shlomi-noach @dbussink @frouioui