Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mysqlctl: Error out on stale socket #14650

Merged
merged 2 commits into from
Nov 30, 2023
Merged

mysqlctl: Error out on stale socket #14650

merged 2 commits into from
Nov 30, 2023

Conversation

dbussink
Copy link
Contributor

When we see a stale socket file, it's not useful to try and start MySQL since we're going to fail to start it anyway.

In that case it's better to error out immediately and either a human or computer operator can try to fix the situation and retry instead of waiting for wait_time which is useless at this point.

Related Issue(s)

This is a follow up to #14553 & #14600 to better handle #14552

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@dbussink
mysqlctl: Error out on stale socket
a7a2595 
When we see a stale socket file, it's not useful to try and start MySQL
since we're going to fail to start it anyway.

In that case it's better to error out immediately and either a human or
computer operator can try to fix the situation and retry instead of
waiting for `wait_time` which is useless at this point.

Signed-off-by: Dirkjan Bussink <[email protected]>
@vitess-bot vitess-bot
Copy link
Contributor

vitess-bot bot commented Nov 30, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 30, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 30, 2023
@frouioui frouioui added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: TabletManager and removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 30, 2023
@dbussink dbussink added Type: Bug and removed Type: Enhancement Logical improvement (somewhere between a bug and feature) labels Nov 30, 2023
mattlord
mattlord approved these changes Nov 30, 2023
View reviewed changes
Copy link
Contributor

@mattlord mattlord left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I only had one comment about the log line params.

go/vt/mysqlctl/mysqld.go Outdated Show resolved Hide resolved
@dbussink
Fix argument ordering
0f6d731 
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink merged commit fabc23c into vitessio:main Nov 30, 2023
116 checks passed
@dbussink dbussink deleted the dbussink/error-on-stale-socket branch November 30, 2023 17:31
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
@dbussink @ejortegau
mysqlctl: Error out on stale socket (vitessio#14650)
c5ee488 
Signed-off-by: Dirkjan Bussink <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuptaManan100 GuptaManan100 GuptaManan100 approved these changes

@frouioui frouioui frouioui approved these changes

@mattlord mattlord mattlord approved these changes

@deepthi deepthi Awaiting requested review from deepthi deepthi is a code owner

Assignees
No one assigned
Labels
Component: TabletManager Type: Bug
Projects
None yet
Milestone
v19.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@dbussink @mattlord @frouioui @GuptaManan100