Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evalengine: Improve the typing situation for functions #14533

Merged
merged 7 commits into from
Nov 20, 2023

Conversation

dbussink
Copy link
Contributor

There are a number of functions like unix_timestamp that have more subtle typing properties and who need additional information. This adds logic to track sizing so we can return the correct type also for those functions.

This removes the last ambiguous typing we have here and fixes a number of queries.

Related Issue(s)

Fixes #14340

Checklist

  • "Backport to:" labels have been added if this change should be back-ported
  • Tests were added or are not required
  • Did the new or modified tests pass consistently locally and on the CI
  • Documentation was added or is not required

@dbussink dbussink added Type: Enhancement Logical improvement (somewhere between a bug and feature) Component: Evalengine changes to the evaluation engine labels Nov 16, 2023
Copy link
Contributor

vitess-bot bot commented Nov 16, 2023

Review Checklist

Hello reviewers! 👋 Please follow this checklist when reviewing this Pull Request.

General

  • Ensure that the Pull Request has a descriptive title.
  • Ensure there is a link to an issue (except for internal cleanup and flaky test fixes), new features should have an RFC that documents use cases and test cases.

Tests

  • Bug fixes should have at least one unit or end-to-end test, enhancement and new features should have a sufficient number of tests.

Documentation

  • Apply the release notes (needs details) label if users need to know about this change.
  • New features should be documented.
  • There should be some code comments as to why things are implemented the way they are.
  • There should be a comment at the top of each new or modified test to explain what the test does.

New flags

  • Is this flag really necessary?
  • Flag names must be clear and intuitive, use dashes (-), and have a clear help text.

If a workflow is added or modified:

  • Each item in Jobs should be named in order to mark it as required.
  • If the workflow needs to be marked as required, the maintainer team must be notified.

Backward compatibility

  • Protobuf changes should be wire-compatible.
  • Changes to _vt tables and RPCs need to be backward compatible.
  • RPC changes should be compatible with vitess-operator
  • If a flag is removed, then it should also be removed from vitess-operator and arewefastyet, if used there.
  • vtctl command output order should be stable and awk-able.

@vitess-bot vitess-bot bot added NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsIssue A linked issue is missing for this Pull Request NeedsWebsiteDocsUpdate What it says labels Nov 16, 2023
@github-actions github-actions bot added this to the v19.0.0 milestone Nov 16, 2023
@dbussink dbussink force-pushed the dbussink/improve-evalengine-typing branch from f436589 to 6ac083d Compare November 16, 2023 15:04
@dbussink dbussink removed NeedsDescriptionUpdate The description is not clear or comprehensive enough, and needs work NeedsWebsiteDocsUpdate What it says NeedsIssue A linked issue is missing for this Pull Request labels Nov 16, 2023
@dbussink dbussink force-pushed the dbussink/improve-evalengine-typing branch from 6ac083d to 6223d67 Compare November 16, 2023 15:18
dbussink and others added 7 commits November 20, 2023 12:13
There are a number of functions like `unix_timestamp` that have more
subtle typing properties and who need additional information. This adds
logic to track sizing so we can return the correct type also for those
functions.

This removes the last ambiguous typing we have here and fixes a number
of queries.

Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
@dbussink dbussink force-pushed the dbussink/improve-evalengine-typing branch from 7d6c370 to 1879450 Compare November 20, 2023 11:13
@vmg vmg merged commit 04afc33 into vitessio:main Nov 20, 2023
118 checks passed
@vmg vmg deleted the dbussink/improve-evalengine-typing branch November 20, 2023 11:42
ejortegau pushed a commit to slackhq/vitess that referenced this pull request Dec 13, 2023
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Co-authored-by: Vicent Marti <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Evalengine changes to the evaluation engine Type: Enhancement Logical improvement (somewhere between a bug and feature)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: support SELECT UNIX_TIMESTAMP(UTC_TIMESTAMP()) AS unix_utc_ts syntax
3 participants