-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evalengine: Improve the typing situation for functions #14533
Merged
vmg
merged 7 commits into
vitessio:main
from
planetscale:dbussink/improve-evalengine-typing
Nov 20, 2023
Merged
evalengine: Improve the typing situation for functions #14533
vmg
merged 7 commits into
vitessio:main
from
planetscale:dbussink/improve-evalengine-typing
Nov 20, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbussink
added
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Component: Evalengine
changes to the evaluation engine
labels
Nov 16, 2023
dbussink
requested review from
deepthi,
harshit-gangal,
mattlord,
systay,
frouioui,
GuptaManan100 and
arthurschreiber
as code owners
November 16, 2023 14:46
Review ChecklistHello reviewers! 👋 Please follow this checklist when reviewing this Pull Request. General
Tests
Documentation
New flags
If a workflow is added or modified:
Backward compatibility
|
vitess-bot
bot
added
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsIssue
A linked issue is missing for this Pull Request
NeedsWebsiteDocsUpdate
What it says
labels
Nov 16, 2023
dbussink
force-pushed
the
dbussink/improve-evalengine-typing
branch
from
November 16, 2023 15:04
f436589
to
6ac083d
Compare
dbussink
removed
NeedsDescriptionUpdate
The description is not clear or comprehensive enough, and needs work
NeedsWebsiteDocsUpdate
What it says
NeedsIssue
A linked issue is missing for this Pull Request
labels
Nov 16, 2023
dbussink
force-pushed
the
dbussink/improve-evalengine-typing
branch
from
November 16, 2023 15:18
6ac083d
to
6223d67
Compare
systay
reviewed
Nov 16, 2023
systay
reviewed
Nov 16, 2023
There are a number of functions like `unix_timestamp` that have more subtle typing properties and who need additional information. This adds logic to track sizing so we can return the correct type also for those functions. This removes the last ambiguous typing we have here and fixes a number of queries. Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Vicent Marti <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
Signed-off-by: Dirkjan Bussink <[email protected]>
dbussink
force-pushed
the
dbussink/improve-evalengine-typing
branch
from
November 20, 2023 11:13
7d6c370
to
1879450
Compare
vmg
approved these changes
Nov 20, 2023
systay
approved these changes
Nov 20, 2023
ejortegau
pushed a commit
to slackhq/vitess
that referenced
this pull request
Dec 13, 2023
Signed-off-by: Dirkjan Bussink <[email protected]> Signed-off-by: Vicent Marti <[email protected]> Co-authored-by: Vicent Marti <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Component: Evalengine
changes to the evaluation engine
Type: Enhancement
Logical improvement (somewhere between a bug and feature)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of functions like
unix_timestamp
that have more subtle typing properties and who need additional information. This adds logic to track sizing so we can return the correct type also for those functions.This removes the last ambiguous typing we have here and fixes a number of queries.
Related Issue(s)
Fixes #14340
Checklist