Fix sdl2_mixer cmake. Fix sdl2 sattelites not using Release build type

[isage]

No description provided.

[sharkwouter]

This will cause a conflict with #283

[isage]

Well, either that, or have completely broken sdl2_mixer

[sharkwouter]

You might want to either include a checksum here or use git+https://github.com/libsdl-org/SDL_mixer.git#commit=${gitrev} as source to use git.

[isage]

github archives aren't guaranteed to have same checksum

[sharkwouter]

Fair, will add a suggestion then.

[sharkwouter]

In what way is it broken? Makepkg strips debug symbols regardless of build type.

[isage]

In what way is it broken? Makepkg strips debug symbols regardless of build type.

1. it fails to link, because it doesn't properly list ogg as dependency for vorbis/flac

/usr/local/vitasdk/bin/../lib/gcc/arm-vita-eabi/10.3.0/../../../../arm-vita-eabi/bin/ld: /usr/local/vitasdk/bin/../lib/gcc/arm-vita-eabi/10.3.0/../../../../arm-vita-eabi/lib/libFLAC.a(ogg_decoder_aspect.o): in function `FLAC__ogg_decoder_aspect_init':
(.text+0x8): undefined reference to `ogg_stream_init'

this is fixed upstream (but they broke libxmp and other stuff doing that)
2. build type isn't just debug symbols.
Default build

/usr/local/vitasdk/bin/arm-vita-eabi-g++ -D__VITA__ -I/home/isage/dev/nxengine/ironhead/deps -I/home/isage/dev/nxengine/ironhead -isystem /usr/local/vitasdk/arm-vita-eabi/include/SDL2 -Wl,-q   -Wall -std=gnu++17 -MD -MT CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj -MF CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj.d -o CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj -c /home/isage/dev/nxengine/ironhead/src/ResourceManager.cpp

Release build

/usr/local/vitasdk/bin/arm-vita-eabi-g++ -D__VITA__ -I/home/isage/dev/nxengine/ironhead/deps -I/home/isage/dev/nxengine/ironhead -isystem /usr/local/vitasdk/arm-vita-eabi/include/SDL2 -Wl,-q -O3 -DNDEBUG   -Wall -std=gnu++17 -MD -MT CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj -MF CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj.d -o CMakeFiles/ironhead.dir/src/ResourceManager.cpp.obj -c /home/isage/dev/nxengine/ironhead/src/ResourceManager.cpp

Or,

//c flags (default)
CMAKE_C_FLAGS:STRING=

//c Debug flags
CMAKE_C_FLAGS_DEBUG:STRING=-O0 -g -DDEBUG -D_DEBUG

//Flags used by the C compiler during MINSIZEREL builds.
CMAKE_C_FLAGS_MINSIZEREL:STRING=-Os -DNDEBUG

//c Release flags
CMAKE_C_FLAGS_RELEASE:STRING=-O3 -DNDEBUG

//Flags used by the C compiler during RELWITHDEBINFO builds.
CMAKE_C_FLAGS_RELWITHDEBINFO:STRING=-O2 -g -DNDEBUG

3. rn it's built with dynamic support for ogg/opus:

DEBUG: Failed loading libvorbisfile.a: SDL_LoadObject() not implemented
DEBUG: OGG support not available
DEBUG: Failed loading libopusfile.a: SDL_LoadObject() not implemented
DEBUG: OPUS support not available
DEBUG: Failed loading libvorbisfile.a: SDL_LoadObject() not implemented

[sharkwouter]

Oh damn, I knew a lot of the cmake scripts for SDL2_mixer were pretty broken, but this is worse than I thought.

[d3m3vilurr]

all done & LGTM
i'll merge it after CI process.