-
-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve jinja spacing #413
Improve jinja spacing #413
Conversation
remove the jinja[spacing] section from the ansible-lint configuration and address lint errors
First and foremost, thank you for your contribution to the project. Your efforts towards improving jinja spacing are greatly appreciated, and your attention to detail is commendable. However, I'd like to bring up the topic of removing all | bool occurrences. The use of the | bool filter in Ansible is considered a good practice. It ensures consistent boolean interpretation across various possible representations, such as "True", "true", "yes", "on", "1", etc. The | bool filter ensures these values are interpreted in their boolean representation, facilitating comparisons and usage in conditionals among others. If you've encountered a situation where | bool is misused or not needed, that might indeed be a case for correction. But removing all occurrences of | bool without appropriate analysis and evaluation might lead to unforeseen consequences. Looking forward to your thoughts on this. |
I didn't know that I will immediately replace all occurrences of |
@ThomasSanson What do you think about |
I am in the process of reverting back regarding the If you agree, I can create an issue for us to discuss the pros and cons of using it. |
thread for discussion of the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed the task of reviewing all 28 files.
I can confirm that everything is in order from my perspective.
Great job, @pa-decarvalho, and thank you! 🎉🙏
Now, let's move on to the next task! 💪😊
This pull request aims to improve jinja spacing. To achieve this, the
jinja[spacing]
section has been removed from the.config/ansible-lint.yml
file.While making the correction, I came across the following
variable | bool
and decided to remove all| bool
occurrences from the project as they are not necessary. Feel free to let me know if I should create another PR for this part or revert the change.