Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the Molecule tests for the Type C schema (Consul) #375

Closed
vitabaks opened this issue Jun 10, 2023 · 4 comments
Closed

Add the Molecule tests for the Type C schema (Consul) #375

vitabaks opened this issue Jun 10, 2023 · 4 comments
Assignees

Comments

@vitabaks
Copy link
Owner

vitabaks commented Jun 10, 2023

Issue Description:

As part of our ongoing commitment to code quality and robust testing, we've identified the need to implement Molecule tests for the Type C schema, specifically for Consul. Currently, this component lacks the appropriate Molecule tests which are crucial in ensuring its functionality and reliability.

Proposed Solution:

The goal is to add Molecule tests for the Consul cluster of the (Type C schema). These tests will assess the functionality of the Consul component and ensure that it works as expected within the larger schema. This would greatly enhance your confidence in the stability of the system and its resilience to various edge cases.

Benefits:

Implementing these tests will:

  1. Increase the robustness of our testing suite.
  2. Enhance the reliability of the Type C schema.
  3. Help identify and potential bugs or issues.

We welcome any contributions or thoughts on how best to approach this. Thank you for considering this request.

@ThomasSanson
Copy link
Contributor

Hello @vitabaks,

I agree with the importance of implementing Molecule tests for the Type C schema, specifically for Consul. This is crucial for ensuring the functionality and reliability of this component.

However, I wanted to suggest a slightly different approach for implementing these tests. Could we consider using the matrix option of Github Actions per Molecule scenario? This way, we could test all necessary OS versions per scenario. You can find more information about this in the Github documentation.

An alternative would be to directly mix the different OS in Molecule platforms, although I'm less keen on this approach.

In any case, this will have a significant impact on the CI, but I don't think we have many options.

Finally, a future solution could be to split the building blocks (HA Proxy, Consul, Postgres, Keepalive, etc.) into different projects and to keep this one as the central one thanks to collections.

What do you think?

@vitabaks
Copy link
Owner Author

No, I don't think it's necessary to separate cluster components. It is necessary to test the entire cluster scheme (including these components).

thanks for the comments and any ideas.

I will take on this task.

@ThomasSanson
Copy link
Contributor

@vitabaks

I suggest that we switch to Collection mode initially (work in progress with @pa-decarvalho), and from there, we will have a folder organization and thus a more "clean" structure to delve into various testing scenarios and refactoring.

@vitabaks
Copy link
Owner Author

Done #511

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@vitabaks @ThomasSanson and others