-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #98: Add support for 16-bit floating point numbers #100
Conversation
@Bodigrim I understand that you are doing maintenance for this package at this point. Would you accept a pull request to fix this issue? This is largely affecting the newest distributions of macOS that modified |
Adding new constructors to exported data types is a breaking change unfortunately. Not a big deal, just bump the major version please. @jcmartin I am more of caretaker than maintainer, I don't really have any proper domain knowledge. If someone is capable to review, I'll be happy to merge and release. @vmchale given your comment in #98, might you be interested to take a look? |
@Bodigrim Fair enough. If it is alright, do you mind if we do two pull requests? One that does not have bfloat16 and one that adds it as well. This way people can benefit from the This only works if both 0.9.5 and 0.10.0 will be published though. |
To be frank, I don't have that much bandwidth. It's easier to revise the latest release of |
I have bumped the version to 0.10.0. |
I tested jcmartin's patch, building a version of c2hs with his language-c-0.9.5. It successfully parsed the |
I'm trying to get |
@Bodigrim I will try to take a look at this in the next few days. My initial take on macOS was that some of the tests were failing because the compiler messages appear different depending if they arise from a macro or not. Fixing this the correct way would be rather annoying as it would require tracking when the compiler changed the messages and performing a different test depending on the compiler. It may also be the case that the version that Apple ships has a different output than what is available via your favorite package manager. I have not run |
I have not looked at the testing framework, maybe we can sanitize / filter certain lines to achieve uniform behavior? I'm also on macOS, one way to run I'd like to have an evidence that tests pass at least for one platform. If it happens to be easier to achieve for Linux / GCC instead of macOS / clang, that's fine. |
I ran these |
Awesome, published: https://hackage.haskell.org/package/language-c-0.10.0 |
This adds support for the following 16-bit floating point numbers:
__fp16
,_Float16
, and_Float16x
.__bf16
.This change does not cause any breaking changes and so the minor version was bumped.