Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid adding props to global function prototype. Doing so breaks the react-three-fiber reconciler #9207

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Avoid adding props to global function prototype. Doing so breaks the react-three-fiber reconciler #9207

wants to merge 5 commits into from

Commits on Oct 10, 2024

  1. Avoid adding props to global function prototype. Doing so breaks the … 

    …react-three-fiber reconciler and prevents it from detecting when event handlers have changed and need to be updated in the underlying three.js objects.
    @marsy-invests
    marsy-invests committed Oct 10, 2024
    Configuration menu
    Copy the full SHA
    12cdef9 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Revised props caching fix due to failing tests.

    @marsy-invests
    marsy-invests committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    6832a4b View commit details
    Browse the repository at this point in the history

  2. Fixed linting issues

    @marsy-invests
    marsy-invests committed Oct 11, 2024
    Configuration menu
    Copy the full SHA
    1d3393f View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into master

    @marsy-invests
    marsy-invests authored Oct 11, 2024
    Configuration menu
    Copy the full SHA
    e846166 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Merge branch 'master' into master

    @marsy-invests
    marsy-invests authored Oct 23, 2024
    Configuration menu
    Copy the full SHA
    702d715 View commit details
    Browse the repository at this point in the history