Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move publish target to es2020 #9188

Merged
merged 1 commit into from
Sep 27, 2024
Merged

Move publish target to es2020 #9188

merged 1 commit into from
Sep 27, 2024

Conversation

Pessimistress
Copy link
Collaborator

See #9183

Input:

export default class Deck {
   static defaultProps = defaultProps;
   static VERSION = VERSION; 
}

Output targeting ES2022:

export default class Deck {
    static { this.defaultProps = defaultProps; }
    static { this.VERSION = VERSION; }
}

Output targeting ES2020:

class Deck {
}
Deck.defaultProps = defaultProps;
Deck.VERSION = VERSION;
export default Deck;

@coveralls
Copy link

Coverage Status

coverage: 91.733%. remained the same
when pulling 4178b33 on x/target
into 0b8fdd8 on master.

Copy link
Collaborator

@ibgreen ibgreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Interestingly, the TypeScript target docs only talk about "downleveling" seems we had a case of "upleveling" happening here: https://www.typescriptlang.org/tsconfig/#target

@Pessimistress Pessimistress changed the title Discussion: move publish target to es2020 Move publish target to es2020 Sep 27, 2024
@Pessimistress Pessimistress marked this pull request as ready for review September 27, 2024 15:10
@Pessimistress Pessimistress merged commit 0516ce1 into master Sep 27, 2024
4 checks passed
@Pessimistress Pessimistress deleted the x/target branch September 27, 2024 15:11
Pessimistress added a commit that referenced this pull request Sep 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants